Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Cherry pick PR #40655 to staging 🍒 #40665

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

os-botify[bot]
Copy link

@os-botify os-botify bot commented Apr 21, 2024

🍒 Cherry pick #40655 to staging 🍒

OSBotify and others added 2 commits April 21, 2024 21:31
(cherry picked from commit acd2974)
[CP Staging] Fix/40543: IOU - Currency in the amount editor is USD when the request is created in local currency

(cherry picked from commit 8e8b173)
@os-botify os-botify bot requested a review from a team as a code owner April 21, 2024 21:31
@os-botify
Copy link
Author

os-botify bot commented Apr 21, 2024

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team April 21, 2024 21:32
Copy link

melvin-bot bot commented Apr 21, 2024

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -184,10 +184,10 @@ export default withWritableReportOrNotFound(
return `${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transactionID}`;
},
},
backupTransaction: {
draftTransaction: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mountiny
Copy link
Contributor

Tested the flow from #40655 works well

Screen.Recording.2024-04-21.at.23.47.21.mp4

Copy link
Contributor

@srikarparsi srikarparsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and looks like it tests well

@srikarparsi
Copy link
Contributor

Merging without checklists as per slack.

@srikarparsi srikarparsi merged commit f8d48b8 into staging Apr 21, 2024
4 of 7 checks passed
@srikarparsi srikarparsi deleted the mountiny-cherry-pick-staging-40655-1 branch April 21, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants