-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search v1] Add empty search List skeleton #40682
[Search v1] Add empty search List skeleton #40682
Conversation
64a981c
to
d4670d4
Compare
@@ -59,6 +61,7 @@ function SearchPageBottomTab() { | |||
/> | |||
))} | |||
</View> | |||
{/* <EmptySearchView /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this here for ease of reviewing, I can clean this up before final merge.
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb Safarisafari.movMacOS: Chrome / Safariweb.movsearch-web.movMacOS: Desktopdesktop.mov |
No need for C+ review on this one. We're still developing the feature and this is unused in App. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.65-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Details
EmptySearchView
component that displays skeleton view of search list loadingOptionsListSkeletonView
partially according to design doc to extract some common behavior to a componentEmptySearchView
because otherwise there is no way to see how this behavesFixed Issues
$ #39882
PROPOSAL:
Tests
SearchPage
andSearchPageBottomTab
and uncomment the usages of new component to see if it worksOffline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
rec-skeleton-andr.mp4
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-22.at.12.16.59.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
rec-skeleton-web.mp4
MacOS: Desktop