-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix confirmation page isn't closed after completing share expense #40740
Fix confirmation page isn't closed after completing share expense #40740
Conversation
@@ -3072,6 +3072,7 @@ function trackExpense( | |||
} | |||
} | |||
if (action === CONST.IOU.ACTION.SHARE) { | |||
Navigation.dismissModal(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will just close the modal without navigating the user to the report chat and will only navigate to the report chat after inviting the user (@jjcoffee as you mentioned here)/go back from the invite page.
Do we want to navigate the user after submitting the expense? Here is how it looks:
Screen.Recording.2024-04-23.at.10.25.59.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think it makes sense to immediately navigate upon submitting the expense, but there may be some reason why this was not implemented and I'm not sure it's really within scope for this PR - it's more of a polish thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked on Slack!
This comment was marked as resolved.
This comment was marked as resolved.
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-app-2024-04-23_12.11.01.mp4Android: mWeb Chromeandroid-chrome-2024-04-23_12.14.56.mp4iOS: Nativeios-app-2024-04-23_13.52.09.mp4iOS: mWeb Safariios-safari-2024-04-23_14.07.50.mp4MacOS: Chrome / Safaridesktop-chrome-2024-04-23_11.21.52.mp4MacOS: Desktopdesktop-app-2024-04-23_11.43.24.mp4 |
Fixed this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the extra fix!
@thienlnam All yours! Just a side-note, I've decided that changing the point at which we navigate to the workspace is OOS for this PR (and to keep it moving quickly) as it's more of a polish issue from the original PR rather than a bug per se. I also wasn't able to get confirmation on Slack whether or not it was intentional. Anyway, here's how it currently works in case you disagree. Note that we don't navigate to the workspace until after the invite screen is interacted with (either back button press to dismiss, or select some member(s) to invite), even though the expense is submitted/moved in the previous step. desktop-chrome-2024-04-23_11.21.52.mp4 |
Yeah that's fine for now, we can do some follow up polish in another issue - thanks for the urgency! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.65-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Details
When we share an expense to a workspace, it will open an invite page. But if we go back, it will navigate back the user to the confirmation page again.
Fixed Issues
$ #40490
PROPOSAL: #40490 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-23.at.10.20.39.mov
Android: mWeb Chrome
Screen.Recording.2024-04-23.at.10.16.38.mov
iOS: Native
Screen.Recording.2024-04-23.at.10.21.21.mov
iOS: mWeb Safari
Screen.Recording.2024-04-23.at.10.00.53.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-23.at.09.57.45.mov
MacOS: Desktop
Screen.Recording.2024-04-23.at.09.58.31.mov