[No QA][TS migration] Adjust ESLint and TS configs

.eslintignore

@@ -1,5 +1,11 @@
-**/node_modules/*
-**/dist/*
-android/**/build/*
-.github/actions/**/index.js"
+!.storybook
+!.github
+.github/actions/**/index.js
+*.config.js
+**/.eslintrc.js
+**/node_modules/**
+**/dist/**
+android/**/build/**
 docs/vendor/**
+docs/assets/**
+web/gtm.js

.github/.eslintrc.js

@@ -1,6 +1,10 @@
-// For all these Node.js scripts, we do not want to disable `console` statements
 module.exports = {
     rules: {
+        // For all these Node.js scripts, we do not want to disable `console` statements
         'no-console': 'off',
+
+        '@lwc/lwc/no-async-await': 'off',
+        'no-await-in-loop': 'off',
+        'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
     },
 };

src/components/tagPropTypes.js

@@ -8,6 +8,7 @@ const tagListPropTypes = PropTypes.shape({
     enabled: PropTypes.bool.isRequired,
 
     /** "General Ledger code" that corresponds to this tag in an accounting system. Similar to an ID. */
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     'GL Code': PropTypes.string,
 });
 

src/pages/EnablePayments/IdologyQuestions.tsx

@@ -1,6 +1,5 @@
 import React, {useState} from 'react';
 import {View} from 'react-native';
-import type {WalletAdditionalQuestionDetails} from 'src/types/onyx';
 import FormProvider from '@components/Form/FormProvider';
 import InputWrapper from '@components/Form/InputWrapper';
 import type {FormInputErrors, FormOnyxValues} from '@components/Form/types';
@@ -13,6 +12,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import * as BankAccounts from '@userActions/BankAccounts';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
+import type {WalletAdditionalQuestionDetails} from '@src/types/onyx';
 import type {Errors} from '@src/types/onyx/OnyxCommon';
 
 const MAX_SKIP = 1;

tests/.eslintrc.js

@@ -1,5 +1,21 @@
 module.exports = {
+    extends: ['plugin:testing-library/react'],
     rules: {
         'no-import-assign': 'off',
+        '@lwc/lwc/no-async-await': 'off',
+        'no-await-in-loop': 'off',
+        'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
+
+        // This helps disable the `prefer-alias` rule for tests
+        '@dword-design/import-alias/prefer-alias': ['off'],
+
+        'testing-library/await-async-queries': 'error',
+        'testing-library/await-async-utils': 'error',
+        'testing-library/no-debugging-utils': 'error',
+        'testing-library/no-manual-cleanup': 'error',
+        'testing-library/no-unnecessary-act': 'error',
+        'testing-library/prefer-find-by': 'error',
+        'testing-library/prefer-presence-queries': 'error',
+        'testing-library/prefer-screen-queries': 'error',
     },
 };

tsconfig.json

@@ -1,37 +1,12 @@
 {
     "$schema": "https://json.schemastore.org/tsconfig",
+    "extends": "expo/tsconfig.base",
     "compilerOptions": {
-        "target": "esnext",
         "module": "commonjs",
         "types": ["react-native", "jest"],
-        "lib": [
-            "DOM",
-            "es2019",
-            "es2020.bigint",
-            "es2020.date",
-            "es2020.number",
-            "es2020.promise",
-            "es2020.string",
-            "es2020.symbol.wellknown",
-            "es2021.promise",
-            "es2021.string",
-            "es2021.weakref",
-            "es2022.array",
-            "es2022.object",
-            "es2022.string",
-            "ES2021.Intl",
-            "ES2023.Array"
-        ],
-        "allowJs": true,
-        "checkJs": false,
-        "jsx": "react-native",
-        "noEmit": true,
         "isolatedModules": true,
         "strict": true,
-        "moduleResolution": "node",
-        "resolveJsonModule": true,
         "allowSyntheticDefaultImports": true,
-        "skipLibCheck": true,
         "incremental": true,
         "baseUrl": ".",
         "paths": {
@@ -48,7 +23,6 @@
             "@userActions/*": ["./src/libs/actions/*"]
         }
     },
-    "exclude": ["**/node_modules/*", "**/dist/*", ".github/actions/**/index.js", "**/docs/*"],
     "include": ["src", "desktop", "web", "website", "docs", "assets", "config", "tests", "jest", "__mocks__", ".github/**/*", ".storybook/**/*", "workflow_tests", "scripts"],
-    "extends": "expo/tsconfig.base"
+    "exclude": ["**/node_modules/*", "**/dist/*", ".github/actions/**/index.js", "**/docs/*"]
 }

web/gtm.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-param-reassign, prefer-template */
 (function (w, d, s, l, i) {
     w[l] = w[l] || [];
     w[l].push({'gtm.start': new Date().getTime(), event: 'gtm.js'});

workflow_tests/.eslintrc.js

@@ -0,0 +1,7 @@
+module.exports = {
+    rules: {
+        '@lwc/lwc/no-async-await': 'off',
+        'no-await-in-loop': 'off',
+        'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
+    },
+};

workflow_tests/assertions/platformDeployAssertions.ts

@@ -360,10 +360,10 @@ function assertPostGithubCommentJobExecuted(workflowResult: Step[], didExecute =
             {key: 'IS_PRODUCTION_DEPLOY', value: isProduction ? 'true' : 'false'},
             {key: 'DEPLOY_VERSION', value: '1.2.3'},
             {key: 'GITHUB_TOKEN', value: '***'},
-            {key: 'ANDROID', value: didDeploy ? 'success' : ''},
-            {key: 'DESKTOP', value: didDeploy ? 'success' : ''},
-            {key: 'IOS', value: didDeploy ? 'success' : ''},
-            {key: 'WEB', value: didDeploy ? 'success' : ''},
+            {key: 'ANDROID', value: didDeploy ? 'success' : 'skipped'},
+            {key: 'DESKTOP', value: didDeploy ? 'success' : 'skipped'},
+            {key: 'IOS', value: didDeploy ? 'success' : 'skipped'},
+            {key: 'WEB', value: didDeploy ? 'success' : 'skipped'},
         ]),
     ] as const;