[CP Staging] Changing properties being used by Fullstory #40807

danieldoglas · 2024-04-23T15:37:02Z

Details

After we implemented fullstory, we need to change the keys to use the metadata instead. This depends on other internal PRs, so making a separate pull request for it.

This also adds a check if the current environment is production before trying to run initiate FS

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/389940
$ #40860

Tests

Verify that no errors appear in the JS console
Login into new Expensify
Confirm that the userMetadata onyx key is set

Offline tests

QA Steps

Verify that no errors appear in the JS console
Same as QA
Confirm that you're not seeing a fullstory error on console on staging (from [HOLD for payment 2024-06-06] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] Web - "Error: FullStory is not loaded" console error shows up #40860)

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…gUsedByFullstory

melvin-bot · 2024-04-24T11:24:57Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/fullstory/index.native.ts

src/libs/fullstory/index.ts

mountiny

Looks good, I will add the checklist soon

mountiny · 2024-04-24T11:57:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mountiny · 2024-04-24T12:00:50Z

Could not see any full story related console errors

…UsedByFullstory [CP Staging] Changing properties being used by Fullstory (cherry picked from commit 51372ab)

OSBotify · 2024-04-24T12:53:16Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.65-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

…gingPropertyBeingUsedByFullstory" This reverts commit 51372ab, reversing changes made to e58ec49.

OSBotify · 2024-04-25T13:47:12Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:08:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:26:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-26T22:57:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…ertyBeingUsedByFullstory [CP Staging] Changing properties being used by Fullstory (cherry picked from commit 51372ab)

OSBotify · 2024-05-29T09:42:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:24:49Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:36:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

danieldoglas added 7 commits April 23, 2024 17:25

creating new type for metadata

e4beae4

exporting new object type

346c66d

mapping new key to a specific type

7c96e55

removing unecessary type

d90952e

using new property on native

a28ecff

changing language to metadata

54253b1

changing key to use metadata

56e7e46

danieldoglas added the Internal Requires API changes or must be handled by Expensify staff label Apr 23, 2024

danieldoglas and others added 4 commits April 23, 2024 17:53

addressing lint issues

d90322c

Merge branch 'fullstory-integration' into dsilva_changingPropertyBein…

73616eb

…gUsedByFullstory

typescript issue

5d7a00e

typescript checks again

62f44e6

Base automatically changed from fullstory-integration to main April 23, 2024 17:08

danieldoglas added 3 commits April 23, 2024 21:30

Merge branch 'main' into dsilva_changingPropertyBeingUsedByFullstory

0c5a8c9

adding check for fullstory on production environment

5a22573

prettier

e423af1

danieldoglas changed the title ~~[HOLD Web-Expensify/41777] Changing properties being used by Fullstory~~ Changing properties being used by Fullstory Apr 24, 2024

danieldoglas marked this pull request as ready for review April 24, 2024 11:24

danieldoglas requested a review from a team as a code owner April 24, 2024 11:24

melvin-bot bot removed the request for review from a team April 24, 2024 11:24

melvin-bot bot requested a review from Pujan92 April 24, 2024 11:24

danieldoglas self-assigned this Apr 24, 2024

moving logic to web file

bd6e492

mountiny requested review from mountiny and removed request for Pujan92 April 24, 2024 11:31

mountiny changed the title ~~Changing properties being used by Fullstory~~ [CP Staging] Changing properties being used by Fullstory Apr 24, 2024

mountiny reviewed Apr 24, 2024

View reviewed changes

src/libs/fullstory/index.native.ts Show resolved Hide resolved

prettier

6699362

mountiny reviewed Apr 24, 2024

View reviewed changes

src/libs/fullstory/index.ts Outdated Show resolved Hide resolved

src/libs/fullstory/index.ts Show resolved Hide resolved

changing function to init only if it's not initialized

bdad226

mountiny approved these changes Apr 24, 2024

View reviewed changes

mountiny merged commit 51372ab into main Apr 24, 2024
15 of 17 checks passed

mountiny deleted the dsilva_changingPropertyBeingUsedByFullstory branch April 24, 2024 12:01

OSBotify pushed a commit that referenced this pull request Apr 24, 2024

Merge pull request #40807 from Expensify/dsilva_changingPropertyBeing…

357364f

…UsedByFullstory [CP Staging] Changing properties being used by Fullstory (cherry picked from commit 51372ab)

github-actions bot mentioned this pull request Apr 24, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

mananjadhav added a commit to mananjadhav/App that referenced this pull request Apr 24, 2024

Revert "Merge pull request Expensify#40807 from Expensify/dsilva_chan…

df8d7e3

…gingPropertyBeingUsedByFullstory" This reverts commit 51372ab, reversing changes made to e58ec49.

github-actions bot mentioned this pull request Apr 25, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks

melvin-bot bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-06-06] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] Web - "Error: FullStory is not loaded" console error shows up #40860

Closed

6 tasks

LCOleksii pushed a commit to LCOleksii/App that referenced this pull request May 20, 2024

Merge pull request Expensify#40807 from Expensify/dsilva_changingProp…

dd22a4c

…ertyBeingUsedByFullstory [CP Staging] Changing properties being used by Fullstory (cherry picked from commit 51372ab)

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Changing properties being used by Fullstory #40807

[CP Staging] Changing properties being used by Fullstory #40807

danieldoglas commented Apr 23, 2024 •

edited

Loading

melvin-bot bot commented Apr 24, 2024

mountiny left a comment

mountiny commented Apr 24, 2024 •

edited

Loading

mountiny commented Apr 24, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

[CP Staging] Changing properties being used by Fullstory #40807

[CP Staging] Changing properties being used by Fullstory #40807

Conversation

danieldoglas commented Apr 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 24, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Apr 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny commented Apr 24, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

danieldoglas commented Apr 23, 2024 •

edited

Loading

mountiny commented Apr 24, 2024 •

edited

Loading