Update rn-web to 0.19.12 #40960

bernhardoj · 2024-04-25T04:21:49Z

Details

Updating the rn-web to 0.19.11 to fix the double pressable onPress callback.

Fixed Issues

$ #40602
$ #37464
$ #33502
PROPOSAL: #33502 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

A. Three-dot menu

Open money request page
Enter any amount
Select any participant
In the confirmation page, keep press TAB until the three-dot menu is highlighted
Press ENTER
Verify the menu is shown

B. Composer action menu

Open any chat
Focus on the composer
Press SHIFT+TAB to move the focus to the "+" button
Press ENTER
Verify the composer menu is shown

C. Double back navigation

Open money request page
Enter any amount
Select any participant
Press Description to open description page
Press TAB to focus the Save button
Press ENTER
Verify you are navigated back to the confirmation page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

A.

Screen.Recording.2024-04-25.at.12.01.33.mov

B.

Screen.Recording.2024-04-25.at.12.10.53.mov

C.

Screen.Recording.2024-04-25.at.12.33.35.mov

iOS: Native

iOS: mWeb Safari

A.

Screen.Recording.2024-04-25.at.11.59.42.mov

B.

Screen.Recording.2024-04-25.at.12.09.34.mov

C.

Screen.Recording.2024-04-25.at.12.13.07.mov

MacOS: Chrome / Safari

A.

Screen.Recording.2024-04-25.at.11.57.50.mov

B.

Screen.Recording.2024-04-25.at.12.03.16.mov

C.

Screen.Recording.2024-04-25.at.12.11.52.mov

MacOS: Desktop

A.

Screen.Recording.2024-04-25.at.11.58.25.mov

B.

Screen.Recording.2024-04-25.at.12.03.49.mov

C.

Screen.Recording.2024-04-25.at.12.12.30.mov

melvin-bot · 2024-04-25T04:21:53Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-04-25T04:22:29Z

patches/react-native-web+0.19.9+002+measureInWindow.patch

Patch deleted because it's already merged into 0.19.11

bernhardoj · 2024-04-25T14:14:22Z

Hmm, this rn-web commit that adds passive: true to the wheel listener broke the report screen scrolling. @tienifr can you take a look?

danieldoglas · 2024-04-30T12:26:13Z

bump @tienifr

danieldoglas · 2024-04-30T12:26:23Z

@thesahindia too

tienifr · 2024-05-02T03:27:39Z

@danieldoglas I'm taking a look.

bernhardoj · 2024-05-22T13:39:33Z

Hmm, this rn-web commit that adds passive: true to the wheel listener broke the report screen scrolling. @tienifr can you take a look?

Issue fixed in 0.19.12. I have updated it 0.19.12 and updated the patches too. @mollfpr ready for review now.

danieldoglas · 2024-05-27T16:02:07Z

bump @mollfpr

mollfpr · 2024-05-27T16:22:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

A

40960.mWeb-Chrome.-.A.mp4

B

40960.mWeb-Chrome.-.B.mp4

C

40960.mWeb-Chrome.-.C.mp4

iOS: Native

iOS: mWeb Safari

A

40960.mWeb-Safari.-.A.mov

B

40960.mWeb-Safari.-.B.mov

C

40960.mWeb-Safari.-.C.mov

MacOS: Chrome / Safari

A

40960.Web.-.A.mp4

B

40960.Web.-.B.mp4

C

40960.Web.-.C.mp4

MacOS: Desktop

A

40960.Desktop.-.A.mp4

B

40960.Desktop.-.B.mp4

C

40960.Desktop.-.C.mp4

mollfpr

LGTM 👍

neil-marcellini

Nice, thanks

neil-marcellini · 2024-05-28T17:29:14Z

Holding for the merge freeze unfortunately

neil-marcellini · 2024-05-29T16:31:33Z

The merge freeze is over

OSBotify · 2024-05-29T16:40:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-30T21:53:35Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:30:05Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:56:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 4 commits April 25, 2024 11:53

update rn-web to 0.19.11

31fb094

delete unused patch

75d3316

rename patches

3b90c98

remove workaround

f86d3f7

bernhardoj requested a review from a team as a code owner April 25, 2024 04:21

melvin-bot bot removed the request for review from a team April 25, 2024 04:21

melvin-bot bot requested a review from mollfpr April 25, 2024 04:21

bernhardoj commented Apr 25, 2024

View reviewed changes

patches/react-native-web+0.19.9+002+measureInWindow.patch

Copy link

Contributor Author

bernhardoj Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch deleted because it's already merged into 0.19.11

bernhardoj mentioned this pull request Apr 25, 2024

[HOLD for payment 2023-11-06] [$500] [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event #26990

Closed

Merge branch 'main' into fix/33502-enter-pressable-bug

a732bc4

Merge branch 'main' into fix/33502-enter-pressable-bug

aa819ac

Christinadobrzyn mentioned this pull request May 3, 2024

[HOLD for payment 2024-06-11] [$1000] Web - Three dot menu is not opened via Enter key in Request Money to Add Receipt #33502

Closed

6 tasks

bernhardoj added 3 commits May 22, 2024 20:36

Merge branch 'main' into fix/33502-enter-pressable-bug

2636de3

update rn-web to 0.19.12

7e42812

update patch

fc549e8

bernhardoj changed the title ~~Update rn-web to 0.19.11~~ Update rn-web to 0.19.12 May 22, 2024

mollfpr approved these changes May 27, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini May 27, 2024 17:06

neil-marcellini approved these changes May 28, 2024

View reviewed changes

neil-marcellini changed the title ~~Update rn-web to 0.19.12~~ [HOLD merge freeze] Update rn-web to 0.19.12 May 28, 2024

neil-marcellini changed the title ~~[HOLD merge freeze] Update rn-web to 0.19.12~~ Update rn-web to 0.19.12 May 29, 2024

neil-marcellini merged commit d875e80 into Expensify:main May 29, 2024
21 checks passed

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

sakluger mentioned this pull request Jun 4, 2024

[$250] Chat - Plus/FAB icon menu can't be opened by pressing Enter on keyboard #40602

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-11] [LOW] [Splits] [$500] IOU - App returns to participant selection page when hitting Save with Tab on Description page #37464

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rn-web to 0.19.12 #40960

Update rn-web to 0.19.12 #40960

bernhardoj commented Apr 25, 2024 •

edited

Loading

melvin-bot bot commented Apr 25, 2024

bernhardoj Apr 25, 2024

bernhardoj commented Apr 25, 2024

danieldoglas commented Apr 30, 2024

danieldoglas commented Apr 30, 2024

tienifr commented May 2, 2024

bernhardoj commented May 22, 2024

danieldoglas commented May 27, 2024

mollfpr commented May 27, 2024 •

edited

Loading

mollfpr left a comment

neil-marcellini left a comment

neil-marcellini commented May 28, 2024

neil-marcellini commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

OSBotify commented Jun 4, 2024

Update rn-web to 0.19.12 #40960

Update rn-web to 0.19.12 #40960

Conversation

bernhardoj commented Apr 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 25, 2024

bernhardoj Apr 25, 2024

Choose a reason for hiding this comment

bernhardoj commented Apr 25, 2024

danieldoglas commented Apr 30, 2024

danieldoglas commented Apr 30, 2024

tienifr commented May 2, 2024

bernhardoj commented May 22, 2024

danieldoglas commented May 27, 2024

mollfpr commented May 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini commented May 28, 2024

neil-marcellini commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

OSBotify commented Jun 4, 2024

bernhardoj commented Apr 25, 2024 •

edited

Loading

mollfpr commented May 27, 2024 •

edited

Loading