Fix account type name constants #41155

hayata-suenaga · 2024-04-27T20:28:23Z

Details

This PR:

change the const values to match the backend values (ex. journalEntry -> journal_entry)
changes the const names used for account types
reorganize account type-related translation keys under accounts

Fixed Issues

$ #41154
PROPOSAL: N/A

Tests / QA Steps

Login to New Expensify with an account that is on the accounting beta list
Go to Workspace Settings, enable Accounting feature on the More Features screen, and connect to a US QBO account on the Accounting page.
Make sure that you haven't enabled tax tracking on the workspace you're testing with
After the connection is established with QBO, click the Export button on the menu that appears.
Click `Export out-of-pocket expenses as". Select Journal Entry. Refresh the page. Make sure that Journal Entry is still selected.
Do the above step for Check and Vendor Bill
On the Export page, click "Export company cards as" -> "Export as"
Select Vendor Bill. Refresh the page. Make sure that Vendor Bill is still selected.
Do the same thing for "Credit Card" and "Debit Card"
Change the language of the app to Spanish
Do the same test with Spanish

You might experience the error like the one captured below. These errors are being addressed in other PRs

Offline tests

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-01.at.11.05.24.AM.mov

MacOS: Desktop

This reverts commit d6739e0.

melvin-bot · 2024-04-27T20:28:28Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-04-28T23:33:40Z

This could cause a crash for old QA testers since they may have exportCompanyCard=creditCard saved in onyx where AccountTypeTranslationKeyMapping would return undefined resulting in an invalid translation key. In the tests add a step to sign out if signed in to avoid false positive issues.

s77rt · 2024-04-28T23:42:53Z

xxxRexxxxviewer Checklist (Aldo: changed title to make the checklist check ignore this comment)

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Still experiencing build errors - Not a blocker

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt

Tests well. We just need to use the translation maps in the remaining places where ts is complaining about

aldo-expensify · 2024-04-29T22:45:29Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

+const AccountTypeTranslationKeyMapping = {
+    [CONST.QUICKBOOKS_EXPORT_COMPANY_CARD_ACCOUNT_TYPE.VENDOR_BILL]: 'vendorBill',
+    [CONST.QUICKBOOKS_EXPORT_COMPANY_CARD_ACCOUNT_TYPE.CREDIT_CARD]: 'creditCard',
+    [CONST.QUICKBOOKS_EXPORT_COMPANY_CARD_ACCOUNT_TYPE.DEBIT_CARD]: 'debitCard',
+} as const;


Is this to avoid adding keys with underscore in en/es.ts? so we use debitCard instead of debit_card?
If that is the reason, are we sure we prefer this extra layer? it looks like it is messing up the types too. Shouldn't we just add debit_card in en/es.ts instead?

I think ES Lint is going to complain about it. The type issue you were seeing is from another page for which I forgot to create the mapping. I just pushed a commit to fix it.

But let me know if you still prefer introducing a key with underscores in the es/en files 😄

Maybe if you use constants like this:

App/src/languages/en.ts

Lines 2907 to 2911 in 0ab5b8b

reasons: {

[CONST.EXIT_SURVEY.REASONS.FEATURE_NOT_AVAILABLE]: "I need a feature that's only available in Expensify Classic.",

[CONST.EXIT_SURVEY.REASONS.DONT_UNDERSTAND]: "I don't understand how to use New Expensify.",

[CONST.EXIT_SURVEY.REASONS.PREFER_CLASSIC]: 'I understand how to use New Expensify, but I prefer Expensify Classic.',

},

eslint won't complain? I think it is better to now have this extra layer that we have to keep up to date. Something like this:

hayata-suenaga · 2024-04-29T22:50:43Z

@s77rt, this is ready for another review 😄

hayata-suenaga · 2024-04-29T22:55:55Z

We're duplicating QUICKBOOKS_EXPORT_COMPANY_CARD_ACCOUNT_TYPE in two files. Should we use the underscore translation key and suppress the ES error as Aldo suggested?

hayata-suenaga · 2024-04-29T22:56:53Z

okay I'll change the translation keys to those using undersores

…o export expenses on company card

…suppress ts errors

src/CONST.ts

hayata-suenaga · 2024-05-01T01:47:26Z

building an ad hoc for the testing

s77rt · 2024-05-01T13:18:02Z

Seeing the keys instead of the translations

github-actions · 2024-05-01T17:15:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41155/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41155/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41155/NewExpensify.dmg	https://41155.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hayata-suenaga · 2024-05-01T18:38:36Z

I tested locally. Just in case needed, I'm also building ad hoc with the latest code

github-actions · 2024-05-01T19:11:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41155/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41155/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41155/NewExpensify.dmg	https://41155.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

aldo-expensify

There is an error when following the steps of choosing something for "Export company cards as"

aldo-expensify · 2024-05-01T19:51:31Z

src/types/onyx/Policy.ts

+    exportEntity?: ValueOf<typeof CONST.QUICKBOOKS_OUT_OF_POCKET_EXPENSE_ACCOUNT_TYPE>;
+    exportCompanyCard: ValueOf<typeof CONST.QUICKBOOKS_EXPORT_COMPANY_CARD_ACCOUNT_TYPE>;


NAB: I don't think these keys exportEntity or exportCompanyCard really exist, shouldn't they be reimbursableExpensesExportDestination and nonReimbursableExpensesExportDestination?

This is causing the inputs to start empty because we read the data from non-existing properties

I put this as NAB because this was already wrong and we can fix it in another PR if you prefer.

Ugh, these bad setting names made it to the backend in Auth already because I didn't check if they were correct: https://github.com/Expensify/Auth/blob/3bebe7873f058bdc4f1df5c926f4a3d64f94171a/auth/lib/Policy.h#L111-L140

cc @trjExpensify

These non-existing field values were added in this PR. I completely missed that during the code review.

I don't know why they have added additional fields to the TypeScript definition though. I already question that in this PR, but I should have realized that that also made it to the backend code

ahhh, so that explains why they are empty

Starting to work here: #41463

aldo-expensify · 2024-05-01T19:52:11Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

@@ -21,7 +21,7 @@ function QuickbooksCompanyCardExpenseAccountPage({policy}: WithPolicyConnections
    const styles = useThemeStyles();
    const policyID = policy?.id ?? '';
    const {exportCompanyCardAccount, exportAccountPayable, autoCreateVendor, errorFields, pendingFields, exportCompanyCard} = policy?.connections?.quickbooksOnline?.config ?? {};


NAB: I don't think exportCompanyCardAccount, exportAccountPayable or exportCompanyCard really exists in the backend

these were also added by Nikolay in another PR 😨

aldo-expensify

I'll approve and merge this because it fixes some bad values for constants we have. There is still more work to do, but we can do it in a separate pr.

aldo-expensify · 2024-05-01T22:14:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-05-01T22:25:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-07T01:37:25Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.70-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Hayata Suenaga added 7 commits April 27, 2024 16:06

fix: const strings

d6739e0

Revert "fix: const strings"

46c3531

This reverts commit d6739e0.

fix: string values for the out of pocket expense account options

7f47efe

refactor: const object name

98e6461

fix: string values for the company card export account options

9427bdb

refactor: rename const object

495ecad

refactor: rename const object

35ebb51

hayata-suenaga self-assigned this Apr 27, 2024

hayata-suenaga requested a review from a team as a code owner April 27, 2024 20:28

melvin-bot bot requested review from s77rt and removed request for a team April 27, 2024 20:28

fix: map the account type string value to translation key

b8cdac6

This comment was marked as resolved.

Sign in to view

s77rt reviewed Apr 28, 2024

View reviewed changes

Merge branch 'main' into hayata-fix-account-type-name-constants

0ab5b8b

aldo-expensify reviewed Apr 29, 2024

View reviewed changes

fix: translation key

897e4d8

fix: translation key

a6cd09d

Hayata Suenaga added 4 commits April 29, 2024 16:00

refactor: rename the translation keys for the type of accounts used t…

3060112

…o export expenses on company card

fix: remove the translation key mapping

f936dab

fix: use underscore formatted account type name

4d5b99b

fix: change translation key to match the backend account type name & …

2338c9a

…suppress ts errors

aldo-expensify requested changes Apr 29, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

fix: the const name

3909feb

fix: wrong translation key

e328e0f

hayata-suenaga added the Ready To Build label Apr 30, 2024

trjExpensify mentioned this pull request May 1, 2024

[HOLD for payment 2024-06-03] [QBO] Not all default settings & accounts are selected when establishing the connection to QBO #41046

Closed

6 tasks

This comment has been minimized.

Sign in to view

Hayata Suenaga added 3 commits May 1, 2024 09:38

Merge branch 'main' into hayata-fix-account-type-name-constants

91b078e

fix: translation

6abfbd2

chore: translation key

d0029f6

Hayata Suenaga added 5 commits May 1, 2024 10:51

bring account related translation key under the same property

244be92

fix: remove old translation key

e1d7df2

fix: remove old translation key

b90834a

refactor: rename the translation key

ca5420d

fix: rename outdated translation key

fc6d2a0

hayata-suenaga requested review from s77rt and aldo-expensify May 1, 2024 18:11

Merge branch 'main' into hayata-fix-account-type-name-constants

4a13595

Merge branch 'main' into hayata-fix-account-type-name-constants

8dba03d

aldo-expensify requested changes May 1, 2024

View reviewed changes

aldo-expensify approved these changes May 1, 2024

View reviewed changes

aldo-expensify merged commit 41e3840 into main May 1, 2024
15 of 21 checks passed

aldo-expensify deleted the hayata-fix-account-type-name-constants branch May 1, 2024 22:18

aldo-expensify mentioned this pull request May 1, 2024

Fix QBO config types + fix inputs in config pages #41463

Merged

60 tasks

github-actions bot mentioned this pull request May 2, 2024

Deploy Checklist: New Expensify 2024-05-02 #41494

Closed

60 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix account type name constants #41155

Fix account type name constants #41155

hayata-suenaga commented Apr 27, 2024 •

edited

Loading

melvin-bot bot commented Apr 27, 2024

This comment was marked as resolved.

s77rt commented Apr 28, 2024

s77rt commented Apr 28, 2024 •

edited by aldo-expensify

Loading

s77rt left a comment

aldo-expensify Apr 29, 2024

hayata-suenaga Apr 29, 2024

aldo-expensify Apr 29, 2024 •

edited

Loading

hayata-suenaga commented Apr 29, 2024

hayata-suenaga commented Apr 29, 2024

hayata-suenaga commented Apr 29, 2024

hayata-suenaga commented May 1, 2024

This comment has been minimized.

s77rt commented May 1, 2024 •

edited

Loading

github-actions bot commented May 1, 2024

hayata-suenaga commented May 1, 2024

github-actions bot commented May 1, 2024

aldo-expensify left a comment

aldo-expensify May 1, 2024

aldo-expensify May 1, 2024 •

edited

Loading

hayata-suenaga May 1, 2024 •

edited

Loading

trjExpensify May 1, 2024

aldo-expensify May 1, 2024

aldo-expensify May 1, 2024

hayata-suenaga May 1, 2024

aldo-expensify left a comment

aldo-expensify commented May 1, 2024 •

edited

Loading

OSBotify commented May 1, 2024

OSBotify commented May 7, 2024

	reasons: {
	[CONST.EXIT_SURVEY.REASONS.FEATURE_NOT_AVAILABLE]: "I need a feature that's only available in Expensify Classic.",
	[CONST.EXIT_SURVEY.REASONS.DONT_UNDERSTAND]: "I don't understand how to use New Expensify.",
	[CONST.EXIT_SURVEY.REASONS.PREFER_CLASSIC]: 'I understand how to use New Expensify, but I prefer Expensify Classic.',
	},

		exportEntity?: ValueOf<typeof CONST.QUICKBOOKS_OUT_OF_POCKET_EXPENSE_ACCOUNT_TYPE>;
		exportCompanyCard: ValueOf<typeof CONST.QUICKBOOKS_EXPORT_COMPANY_CARD_ACCOUNT_TYPE>;

Fix account type name constants #41155

Fix account type name constants #41155

Conversation

hayata-suenaga commented Apr 27, 2024 • edited Loading

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 27, 2024

This comment was marked as resolved.

s77rt commented Apr 28, 2024

s77rt commented Apr 28, 2024 • edited by aldo-expensify Loading

xxxRexxxxviewer Checklist (Aldo: changed title to make the checklist check ignore this comment)

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

aldo-expensify Apr 29, 2024

Choose a reason for hiding this comment

hayata-suenaga Apr 29, 2024

Choose a reason for hiding this comment

aldo-expensify Apr 29, 2024 • edited Loading

Choose a reason for hiding this comment

hayata-suenaga commented Apr 29, 2024

hayata-suenaga commented Apr 29, 2024

hayata-suenaga commented Apr 29, 2024

hayata-suenaga commented May 1, 2024

This comment has been minimized.

s77rt commented May 1, 2024 • edited Loading

github-actions bot commented May 1, 2024

hayata-suenaga commented May 1, 2024

github-actions bot commented May 1, 2024

aldo-expensify left a comment

Choose a reason for hiding this comment

aldo-expensify May 1, 2024

Choose a reason for hiding this comment

aldo-expensify May 1, 2024 • edited Loading

Choose a reason for hiding this comment

hayata-suenaga May 1, 2024 • edited Loading

Choose a reason for hiding this comment

trjExpensify May 1, 2024

Choose a reason for hiding this comment

aldo-expensify May 1, 2024

Choose a reason for hiding this comment

aldo-expensify May 1, 2024

Choose a reason for hiding this comment

hayata-suenaga May 1, 2024

Choose a reason for hiding this comment

aldo-expensify left a comment

Choose a reason for hiding this comment

aldo-expensify commented May 1, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented May 1, 2024

OSBotify commented May 7, 2024

hayata-suenaga commented Apr 27, 2024 •

edited

Loading

s77rt commented Apr 28, 2024 •

edited by aldo-expensify

Loading

aldo-expensify Apr 29, 2024 •

edited

Loading

s77rt commented May 1, 2024 •

edited

Loading

aldo-expensify May 1, 2024 •

edited

Loading

hayata-suenaga May 1, 2024 •

edited

Loading

aldo-expensify commented May 1, 2024 •

edited

Loading