fix: Workspace switcher search bar is in the wrong place. #41158

Krishna2323 · 2024-04-27T23:46:31Z

Details

Fixed Issues

$ #40826
PROPOSAL: #40826 (comment)

Tests

Open workspace switcher page and verify the layout matches the designs linked below

Verify that no errors appear in the JS console

Offline tests

Open workspace switcher page and verify the layout matches the designs linked below

QA Steps

Open workspace switcher page and verify the layout matches the designs linked below

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-04-27T23:46:36Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-04-28T22:18:57Z

After fix:

Everything Selected	Workspace Selected

cc: @Expensify/design

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-04-28T22:25:50Z

In the design the input placeholder is Find a workspace and there is a search icon on the left of the input, do we need that as well?

getusha · 2024-05-01T17:19:42Z

@Expensify/design could you please confirm if this is looking as expected? thanks!

shawnborton · 2024-05-01T17:34:56Z

Hmm if we do want to add the icon, I would say we should add it to the right side of the input. Can you try that and show us what it looks like?

getusha · 2024-05-03T19:42:29Z

@Krishna2323 any updates?

Krishna2323 · 2024-05-04T21:40:07Z

can you try that and show us what it looks like?

@shawnborton @getusha, IMO, we shouldn't add this because no other input in the app has this icon, or if we want, we can add this as default for every selection list input.

shawnborton · 2024-05-06T11:42:15Z

IMO, we shouldn't add this because no other input in the app has this icon, or if we want, we can add this as default for every selection list input.

I actually don't mind the idea of making it so that every search box above a selection list uses that same style, which has the magnifying glass. What do you think @Expensify/design ? The alternative is to just omit the Search icon entirely, but I do think the icon helps this particular component look more like a search box and less like a heading.

dannymcclain · 2024-05-06T13:34:07Z

I actually don't mind the idea of making it so that every search box above a selection list uses that same style, which has the magnifying glass.

Yeah I don't think that's a bad idea at all. At the same time, the right side in this workspace switcher is looking a little crazy, so I could be persuaded to drop the icon as well. I'll be happy with whatever you and @dubielzyk-expensify think is best!

shawnborton · 2024-05-06T13:38:38Z

True, but that's a good point - maybe we just need the search icon to be properly aligned all the way to the right side of the input. @Krishna2323 can you try that please?

Krishna2323 · 2024-05-06T14:57:25Z

@dannymcclain @shawnborton, currently the search icon has 8px padding right, if we remove the padding right from the icon it will still not look aligned with above 2 icons, so I reduced it to 4px instead.

Padding right 4px

No Padding

shawnborton · 2024-05-06T14:59:54Z

Hmm that feels like a strange exception to make though, because we can't always guarantee these kinds of inputs will be in the same view as those kinds of list items. So I think I would prefer we just drop the icon altogether if that's the case.

dannymcclain · 2024-05-06T15:09:58Z

Hmm that feels like a strange exception to make though, because we can't always guarantee these kinds of inputs will be in the same view as those kinds of list items. So I think I would prefer we just drop the icon altogether if that's the case.

Yeah same.

dubielzyk-expensify · 2024-05-06T22:19:34Z

Feels like you landed in a good place by dropping it. Makes sense to me 👍

Krishna2323 · 2024-05-07T05:52:05Z

@getusha, I think we don't want to make any changes here, can you pls start reviewing.

getusha · 2024-05-07T06:49:03Z

I think we missed a case, we should include the Everything option to be selectable using a keyboard

Screen.Recording.2024-05-07.at.9.46.49.in.the.morning.mov

Krishna2323 · 2024-05-07T09:01:06Z

@getusha, including the Everything option as a selectable using keyboard will be tricky, can we pls confirm if that is required.

cc: @shawnborton @rlinoz

dannymcclain · 2024-05-07T13:10:34Z

Personally I don't think Everything would be selected via keyboard just by using the arrows keys in the list. I would expect to have to tab up to it. Just my 2 cents.

shawnborton · 2024-05-07T13:13:19Z

Yup, I agree with that

Krishna2323 · 2024-05-07T13:16:19Z

@dannymcclain @shawnborton thanks!

@getusha, you can continue the review.

Krishna2323 · 2024-05-10T06:27:26Z

@getusha, bump for review.

getusha · 2024-05-12T09:34:53Z

BUG: the search input is blurred after opening the workspace switcher

Screen.Recording.2024-05-12.at.12.34.14.in.the.afternoon.mov

dubielzyk-expensify · 2024-05-20T00:20:42Z

The above screenshot brings up an interesting point, cause I'd expect everything to align to the left anchor point of this red line:

So if we chuck the search input in there we'll end up with uneven alignment whether we align it to the workspace avatar or the section header. I'd perfer if everything just has 20px padding from the edge and is aligned the same.

Keen for thoughts from @Expensify/design here on this though

Krishna2323 · 2024-05-20T08:04:14Z

@dubielzyk-expensify @getusha, does this look correct?

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

getusha · 2024-05-20T08:43:03Z

it looks good to me
cc @Expensify/design

dannymcclain · 2024-05-20T13:36:29Z

I'd perfer if everything just has 20px padding from the edge and is aligned the same.

100% agree with Jon.

I think it's looking good—here's a little screenshot with 20px rectangles on the left and right to help visualize the alignment in this comment.

shawnborton · 2024-05-20T13:37:55Z

Also for this one:

the search input is not perfectly aligned, it has unwanted padding-left could you compare it with staging?

Can you pull main? We recently merged this one which might fix some of those issues. Particularly this comment here.

dubielzyk-expensify · 2024-05-21T02:37:30Z

Yep that looks good to me. Defs do what @shawnborton said as well.

Last question for design. Do we want the search icon on the right of the input field or not? I know we've gone back and forth on that one, but forget if we made a call.

shawnborton · 2024-05-21T11:52:08Z

Good question - last I remember, we decided to punt the icon?

Krishna2323 · 2024-05-21T12:52:02Z

@shawnborton @dubielzyk-expensify, Yep we agreed to drop the icon because of the alignment issue. #41158 (comment) #41158 (comment)
#41158 (comment)

getusha · 2024-05-21T18:30:09Z

BUG:Showing a skeleton loading indicator when there is no workspace found matching the search value

dubielzyk-expensify · 2024-05-22T06:11:11Z

Other than the bugs, the visuals look good to me 👍

Krishna2323 · 2024-05-24T10:19:47Z

will fix the bug today.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-05-24T22:07:02Z

@getusha, loading placeholder bug fixed.

getusha · 2024-05-28T12:04:25Z

@Krishna2323 lint is failing

getusha · 2024-05-28T13:00:41Z

src/pages/WorkspaceSwitcherPage/index.tsx

+                        listFooterContent={shouldShowCreateWorkspace ? WorkspaceCardCreateAWorkspaceInstance : null}
+                        initiallyFocusedOptionKey={activeWorkspaceID ?? CONST.WORKSPACE_SWITCHER.NAME}
+                        showLoadingPlaceholder={fetchStatus.status === 'loading' || !didScreenTransitionEnd}
+                    />{' '}


why is this? it's causing a warning on native

showLoadingPlaceholder prop?

@Krishna2323 the {' '}

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

blimpich

LGTM, nice work!

OSBotify · 2024-06-04T17:59:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:31:22Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Workspace switcher search bar is in the wrong place.

0bef6ca

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner April 27, 2024 23:46

melvin-bot bot requested review from getusha and removed request for a team April 27, 2024 23:46

minor fix.

7c396dc

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/40826

960d923

Merge branch 'Expensify:main' into krishna2323/issue/40826

095b03b

Merge branch 'Expensify:main' into krishna2323/issue/40826

b8fe453

update padding horizontal of workspace section header.

5495b7a

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 added 2 commits May 25, 2024 03:10

Merge branch 'Expensify:main' into krishna2323/issue/40826

7fca470

hide loading placeholder when searching.

d98dc37

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/40826

4bfb3ec

getusha reviewed May 28, 2024

View reviewed changes

Krishna2323 added 2 commits June 2, 2024 23:45

Merge branch 'main' into krishna2323/issue/40826

06300cc

remove {' '}.

6d772b5

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

getusha approved these changes Jun 4, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich June 4, 2024 11:15

blimpich approved these changes Jun 4, 2024

View reviewed changes

blimpich merged commit 513c818 into Expensify:main Jun 4, 2024
17 checks passed

github-actions bot mentioned this pull request Jun 6, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

lanitochka17 mentioned this pull request Jun 6, 2024

Workspace - "Find a workspace" text is missing from search bar #43220

Closed

6 tasks

cretadn22 mentioned this pull request Jun 7, 2024

[$250] Workspace switcher - Expensify and workspace are highlighted when navigating by keyboard #43296

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Workspace switcher search bar is in the wrong place #40826

Closed

6 tasks

fix: Workspace switcher search bar is in the wrong place. #41158

fix: Workspace switcher search bar is in the wrong place. #41158

Conversation

Krishna2323 commented Apr 27, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 27, 2024

Krishna2323 commented Apr 28, 2024

After fix:

Krishna2323 commented Apr 28, 2024

getusha commented May 1, 2024

shawnborton commented May 1, 2024

getusha commented May 3, 2024

Krishna2323 commented May 4, 2024 • edited Loading

shawnborton commented May 6, 2024

dannymcclain commented May 6, 2024

shawnborton commented May 6, 2024

Krishna2323 commented May 6, 2024

Padding right 4px

No Padding

shawnborton commented May 6, 2024

dannymcclain commented May 6, 2024

dubielzyk-expensify commented May 6, 2024

Krishna2323 commented May 7, 2024

getusha commented May 7, 2024

Krishna2323 commented May 7, 2024 • edited Loading

dannymcclain commented May 7, 2024

shawnborton commented May 7, 2024

Krishna2323 commented May 7, 2024

Krishna2323 commented May 10, 2024

getusha commented May 12, 2024

dubielzyk-expensify commented May 20, 2024

Krishna2323 commented May 20, 2024

getusha commented May 20, 2024

dannymcclain commented May 20, 2024

shawnborton commented May 20, 2024 • edited Loading

dubielzyk-expensify commented May 21, 2024

shawnborton commented May 21, 2024

Krishna2323 commented May 21, 2024

getusha commented May 21, 2024

dubielzyk-expensify commented May 22, 2024

Krishna2323 commented May 24, 2024

Krishna2323 commented May 24, 2024

getusha commented May 28, 2024

getusha May 28, 2024

Choose a reason for hiding this comment

Krishna2323 May 29, 2024

Choose a reason for hiding this comment

getusha May 29, 2024

Choose a reason for hiding this comment

Krishna2323 Jun 2, 2024

Choose a reason for hiding this comment

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 4, 2024

OSBotify commented Jun 11, 2024

Krishna2323 commented Apr 27, 2024 •

edited

Loading

Krishna2323 commented May 4, 2024 •

edited

Loading

Krishna2323 commented May 7, 2024 •

edited

Loading

shawnborton commented May 20, 2024 •

edited

Loading