Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a left group chat still shows in the search page #41405

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/OptionListContextProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function OptionsListContextProvider({reports, children}: OptionsListProviderProp
}, [reports]);

/**
* This effect is used to add a new report option to the list of options when a new report is added to the collection.
* This effect is used to add a new report option or remove a report option from the list of options when a new report is added to/removed from the collection.
*/
useEffect(() => {
if (!areOptionsInitialized.current || !reports) {
Expand All @@ -95,7 +95,10 @@ function OptionsListContextProvider({reports, children}: OptionsListProviderProp
const missingReportIds = Object.keys(reports).filter((key) => prevReports && !(key in prevReports));

setOptions((prevOptions) => {
const newOptions = {...prevOptions};
const newOptions = {
...prevOptions,
reports: prevOptions.reports.filter((report) => reports[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`] !== null),
};
missingReportIds.forEach((missingReportId) => {
const report = missingReportId ? reports[missingReportId] : null;
if (!missingReportId || !report) {
Expand Down
Loading