Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy to clipboard in long emails #4154

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Conversation

luacmartins
Copy link
Contributor

cc @chiragsalian

Details

Also fixed an issue with the space below display name and Email or Phone, as well as copy to clipboard being shown on user's display name. See screenshot below:

Screen Shot 2021-07-20 at 10 40 50 AM

Fixed Issues

$ #4076

Tests

  1. Open a chat with a user that has a long email address, e.g. applausetester+0118mn@applause.expensifail.com
  2. Tap on user's avatar to open their details page
  3. Verify that the copy to clipboard icon is visible

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mobile-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins requested a review from a team July 20, 2021 19:05
@luacmartins luacmartins self-assigned this Jul 20, 2021
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team July 20, 2021 19:05
@parasharrajat
Copy link
Member

The whole point of using absolute position was that its presence should not affect the layout of the original component.

If we want to remove this feature from the Phone number under the Avatar then it's fine. Otherwise, it would push the phone number under the avatar towards the left.

To fix this just inline the Name and Apply right padding= width of an icon button.

@luacmartins
Copy link
Contributor Author

The feature was removed from the phone number under the avatar.

Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sketchydroide sketchydroide merged commit c52f9f5 into main Jul 26, 2021
@sketchydroide sketchydroide deleted the cmartins-email-copy branch July 26, 2021 14:28
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mananjadhav
Copy link
Collaborator

I am tagging this PR to highlight an issue fixed here. All conditions in ternary expressions or left-hand operands on conditional renders, should be boolean. This PR is one of the PRs that uses conditional render with string operands, hence I am tagging it here for the contributors to check.

We've also updated the item in the checklist with this PR to avoid this issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants