-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copy to clipboard in long emails #4154
Conversation
The whole point of using absolute position was that its presence should not affect the layout of the original component. If we want to remove this feature from the Phone number under the Avatar then it's fine. Otherwise, it would push the phone number under the avatar towards the left. To fix this just inline the Name and Apply right padding= width of an icon button. |
The feature was removed from the phone number under the avatar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.80-3🚀
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
I am tagging this PR to highlight an issue fixed here. All conditions in ternary expressions or left-hand operands on conditional renders, should be boolean. This PR is one of the PRs that uses conditional render with string operands, hence I am tagging it here for the contributors to check. We've also updated the item in the checklist with this PR to avoid this issue in the future. |
cc @chiragsalian
Details
Also fixed an issue with the space below display name and
Email
orPhone
, as well as copy to clipboard being shown on user's display name. See screenshot below:Fixed Issues
$ #4076
Tests
QA Steps
Steps above.
Tested On
Screenshots
Web
web.mov
Mobile Web
mobile-web.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov