Add modal for existing owners error

[jasperhuangg]

Details

Previously, setupWithdrawalAccount would silently error when a user tried to add a withdrawal bank account that we already assigned an owner to.

This PR adds some text similar to the text in Web-Secure.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/169896

Tests

1. Paste this code block here. This'll simulate the server returning with an existingOwners error:

   return new Promise(resolve => resolve({existingOwners: ['patrick@expensify.com', 'spongebob@expensify.com', 'sandy@expensify.com']})).then((response) => {
       const existingOwnersList = response.existingOwners.reduce((ownersStr, owner, i, ownersArr) => {
           let separator = ',\n';
           if (i === 0) {
               separator = '\n';
           } else if (i === ownersArr.length - 1) {
               separator = ' and\n';
           }
           return `${ownersStr}${separator}${owner}`;
       }, '');
       Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false, error: CONST.BANK_ACCOUNT.ERROR.EXISTING_OWNERS, existingOwnersList});
   });

2. Navigate to the add bank account flow for a workspace.
3. Verify that you're unable to add the account since the bank account already has an existing owner, and verify that the error step displays (see screenshots).

QA

1. Create a new workspace and click "Get Started".
2. Add a bank account manually following the steps here.
3. In a different account, follow steps 1 and 2.
4. Verify that you're unable to add the account since the bank account already has an existing owner, and verify that the error step displays (see screenshots).

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Desktop

Mobile-Web

iOS

[shawnborton]

Maybe we don't need that extra padding around the inner message?

[jasperhuangg]

@shawnborton Removed the padding, let me know if there's anything else that catches your eye!

[luacmartins]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.79-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@jasperhuangg While testing this, I noticed only 2 of the current users of the Bank account are displayed. I wanted to verify if there are any limits to how many users are displayed in the modal. For the account I just tried it has a LOT of active owners, that's why I found it weird that only 2 were displayed.

[jasperhuangg]

@isagoico I'm honestly not too sure about this. The code in this PR simply handles displaying the modal with information that was already retrieved from the API. I'll reach out to @marcaaron and ask about this.

[isagoico]

Oh sure, the we could open a separate issue for this and check the PR off since the modal is correctly displayed right?

[roryabraham]

I'm going to check this off on the checklist and run the production deploy. @isagoico Can you create a follow-up issue please? 🙏

[OSBotify]

🚀 Deployed to production in version: 1.0.80-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[marcaaron]

For the account I just tried it has a LOT of active owners, that's why I found it weird that only 2 were displayed.

I honestly also have no idea about this but it sounds like something we should have followed up on.