Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes styling for hidden element #4158

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fixes styling for hidden element #4158

merged 1 commit into from
Jul 22, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jul 21, 2021

Details

  1. Changes the styling of our hiddenElementOutsideOfWindow to be cross-platform.
  2. Takes our hidden Text out of the View that wraps TextInputAutoWidth so that our position: absolute is in relation to the parent component.

Fixed Issues

$ #3296
$ #3355

Tests

QA Steps

  1. Open the app on an iPad Pro in Landscape mode
  2. Start the IOU flow (request money or split bill)
  3. You should be able to type an amount

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mp4

Desktop

desktop.mov

iOS

iOS-iPhone.mp4
aaaaa.mov

Android

ANdroid.mp4

@rdjuric rdjuric requested a review from a team as a code owner July 21, 2021 00:54
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team July 21, 2021 00:54
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can we add screenshots/videos for all platforms to make sure there is no regression?

@rdjuric
Copy link
Contributor Author

rdjuric commented Jul 22, 2021

Updated the PR with videos for all platforms @luacmartins

@rdjuric rdjuric requested a review from luacmartins July 22, 2021 15:30
@luacmartins luacmartins merged commit 4d84b6b into Expensify:main Jul 22, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants