Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for viewing full screen Group Chat custom avatars #41586
Add support for viewing full screen Group Chat custom avatars #41586
Changes from 1 commit
7ce2242
b12d3ef
349ea43
5b6a7c6
66d8edc
7d122da
91f73c8
20294f6
c9993e8
e4ae8b4
b26a166
1e29cab
0b0da6c
10eade0
232e787
8ff95be
284d1f0
3bf6bcf
2992240
a4315b7
f6f582c
cf3f942
b91c010
9c5b15e
c0db9ef
6d6953f
9d4a66f
38d7f5b
530df19
bc18cf6
55b8487
db65135
86fb5e7
12d1da7
3695b6b
16ac2ff
f2e6e7b
1c3e7db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hacky solution. What we can do instead is get the file name and pass it as prop
originalFileName
. This will pass the condition your referenced inAttachmentView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added originalFileName in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the above ^. Since groupChatDraft will pretty much always be set we will not see the not found page in any case. Please update the logic accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove
! groupChatDraft
from above condition then for groupChatDraft it always return not found page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this use the
useOnyx
hook instead. It should help avoid loading the data from onyx if we are not going to use it. Related to the point above ^