Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show IOU preview component persistently #4162

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

tugbadogan
Copy link
Contributor

cc @Julesssss

Details

Added condition to display previously settled IOU reports.

Fixed Issues

$ #4135

Tests

Created and settled 2 IOU reports and confirmed that it works.

QA Steps

  • Click the green + icon and select Request Money
  • Enter an amount and click next
  • Select an attendee and then Request $x to confirm
  • Log-in as the other user that received the request, click pay and I'll settle up elsewhere
  • Observe that there is a preview component on the settled IOU
  • Send another request
  • Observe that the preview components are displayed for all previously settled IOU reports and most recent IOU report.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-07-21 at 13 19 59

Mobile Web

Screenshot 2021-07-21 at 13 20 56

Desktop

Screenshot 2021-07-21 at 13 23 32

iOS

Android

@tugbadogan tugbadogan requested a review from a team as a code owner July 21, 2021 13:56
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team July 21, 2021 13:57
@Julesssss Julesssss merged commit a111b83 into Expensify:main Jul 22, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@tugbadogan tugbadogan deleted the tugbadogan-iou-preview-fix branch July 22, 2021 15:29
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants