[VIP-Travel] Trip room summary #41659

rushatgabhane · 2024-05-06T00:47:31Z

Details

Fixed Issues

$ #37825
PROPOSAL:

Tests

Go to oldDot - staging.expensify.com
Go to travel
Book a flight, rail, car and hotel.
Go to newDot and go to the trip room.
Verify that you see trip room summary, and that it is as per figma

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Backend having some performance issues, so im not getting pusher updates.

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-06T00:47:40Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-05-06T11:36:01Z

src/components/ReportActionItem/TripDetailsView.tsx

+import type {Reservation, ReservationTimeDetails} from '@src/types/onyx/Transaction';
+
+// TODO: to be removed once backend is ready
+const testReservationsList: Reservation[] = [


Can you expand this test to cover all modes, i.e, car, rail, misc?

@rushatgabhane Can you confirm me whether you are working on this or not?

shawnborton · 2024-05-06T12:00:43Z

This spacing from the first part of your PR comment looks good:

But further down in your screenshots section, the spacing here looks different:

rushatgabhane · 2024-05-06T12:43:06Z

The first image is from figma so it looks good 😄

the spacing here looks different

@shawnborton thank you! Let me fix it to match figma

shubham1206agra · 2024-05-10T12:44:47Z

@rushatgabhane Bump here.

rushatgabhane · 2024-05-10T12:47:29Z

@shubham1206agra waiting on newDot to receive backend data - https://expensify.enterprise.slack.com/archives/C05S5EV2JTX/p1715299637326109?thread_ts=1714773700.569819&cid=C05S5EV2JTX

rushatgabhane · 2024-05-13T03:33:14Z

Updated to match figma

shawnborton · 2024-05-13T12:28:12Z

It's still not quite right. We are using 4px gaps between the three lines. The top line should be 16px tall since our label font uses a 16px line height. The middle line should be 20px tall since our regular font uses a 20px line height. And the bottom line should be 14px tall since our micro font size uses a 14px line height.

rushatgabhane · 2024-05-13T16:30:20Z

1. Top line `lineHeight: 16`

2. Middle `lineHeight: 20`

3. Bottom line: `lineHeight: 14px`

4. Fixed the gap to be 4px.

rushatgabhane · 2024-05-30T17:57:48Z

@stitesExpensify all done! Ready for a review again.

Verified that all looks fine -

stitesExpensify

LGTM! @shubham1206agra can we get another review here and the checklist please?

shubham1206agra · 2024-05-31T15:43:56Z

@Expensify/design Can you please confirm the hover design here of icon?

rushatgabhane · 2024-05-31T15:57:32Z

color used for icon is border

@shubham1206agra verified it here - #38808 (comment)

dannymcclain · 2024-05-31T16:21:42Z

@rushatgabhane @shubham1206agra Yup—the container around the icon should use our border color. The icon itself should be colored icon, and then of course the hover background should be rowHover.

rushatgabhane · 2024-06-02T22:46:46Z

@dannymcclain i just merged latest main, the colors now match the design.

stitesExpensify · 2024-06-04T20:27:42Z

@shawnborton mind taking a look and making sure you like the UI here? :)

shawnborton · 2024-06-04T21:13:26Z

Yup all good on my end, we can do another pass at design review in the other PR that is outstanding.

stitesExpensify

LGTM!

OSBotify · 2024-06-04T21:37:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:31:31Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2024-07-18T22:07:54Z

src/components/ReportActionItem/TripDetailsView.tsx

+    const styles = useThemeStyles();
+    const {translate} = useLocalize();
+
+    const tripTransactions = ReportUtils.getTripTransactions(tripRoomReportID);


Just noticed this, but I think this will not trigger a re-render of the component if the transaction gets updated.

shubham1206agra · 2024-08-07T14:44:01Z

We forgot to handle the name of ReportPreview in this room. More details #45344

rushatgabhane added 11 commits May 5, 2024 18:36

add new chat type

7d069ac

add isTripRoom

48d51c4

add isTripRoom

37b5a9d

show trip details in report action item

dc2aba9

pass chatreport id to trip details

942c068

add styles and copy trip details view

770d39e

add dateutils and lang

0079ccc

add reservation type

0d7db37

add assets

26c0c88

add assets

5497a13

add title style to menu item

3adc309

rushatgabhane marked this pull request as ready for review May 6, 2024 00:47

rushatgabhane requested review from a team as code owners May 6, 2024 00:47

melvin-bot bot removed the request for review from a team May 6, 2024 00:47

melvin-bot bot requested a review from shubham1206agra May 6, 2024 00:47

rushatgabhane mentioned this pull request May 6, 2024

[HOLD for payment 2024-06-28] [MEDIUM] Create Trip Room Preview #37826

Closed

shubham1206agra reviewed May 6, 2024

View reviewed changes

Merge branch 'main' into trip-room-2

5865634

rushatgabhane added 2 commits May 12, 2024 21:15

Merge branch 'main' into trip-room-2

dda9361

fix margin and gap for trip summary

5c93faa

fix empty div when no title present

724c980

use font size small

c4b5df5

rushatgabhane dismissed amyevans’s stale review via c4b5df5 May 30, 2024 17:36

use existing styles

22c472e

rushatgabhane mentioned this pull request May 30, 2024

[VIP-Travel] Create Trip Room Preview #38808

Merged

50 tasks

stitesExpensify previously approved these changes May 30, 2024

View reviewed changes

shubham1206agra approved these changes May 31, 2024

View reviewed changes

melvin-bot bot requested a review from amyevans May 31, 2024 16:00

amyevans previously approved these changes May 31, 2024

View reviewed changes

Merge branch 'main' of github.com:rushatgabhane/exfy into trip-room-2

5eba1aa

add hover style

80cd508

rushatgabhane dismissed stale reviews from stitesExpensify and amyevans via 80cd508 June 2, 2024 22:47

prettier

f23f0c1

stitesExpensify approved these changes Jun 4, 2024

View reviewed changes

stitesExpensify merged commit 594ae48 into Expensify:main Jun 4, 2024
15 checks passed

cdOut mentioned this pull request Jun 6, 2024

[Medium] Create Trip Details #37823

Open

github-actions bot mentioned this pull request Jun 6, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [MEDIUM] Create new Trip Room #37825

Closed

luacmartins reviewed Jul 18, 2024

View reviewed changes

shubham1206agra mentioned this pull request Aug 7, 2024

[HOLD for payment 2024-08-07] [$250] [MEDIUM] ReportPreview is showing the incorrect title on a travel booking #45344

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VIP-Travel] Trip room summary #41659

[VIP-Travel] Trip room summary #41659

rushatgabhane commented May 6, 2024 •

edited

Loading

melvin-bot bot commented May 6, 2024

shubham1206agra May 6, 2024

shubham1206agra May 15, 2024

shawnborton commented May 6, 2024

rushatgabhane commented May 6, 2024 •

edited

Loading

shubham1206agra commented May 10, 2024

rushatgabhane commented May 10, 2024

rushatgabhane commented May 13, 2024 •

edited

Loading

shawnborton commented May 13, 2024

rushatgabhane commented May 13, 2024 •

edited

Loading

rushatgabhane commented May 30, 2024 •

edited

Loading

stitesExpensify left a comment

shubham1206agra commented May 31, 2024

rushatgabhane commented May 31, 2024 •

edited

Loading

dannymcclain commented May 31, 2024

rushatgabhane commented Jun 2, 2024

stitesExpensify commented Jun 4, 2024

shawnborton commented Jun 4, 2024

stitesExpensify left a comment

OSBotify commented Jun 4, 2024

OSBotify commented Jun 11, 2024

luacmartins Jul 18, 2024

shubham1206agra commented Aug 7, 2024

[VIP-Travel] Trip room summary #41659

[VIP-Travel] Trip room summary #41659

Conversation

rushatgabhane commented May 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 6, 2024

shubham1206agra May 6, 2024

Choose a reason for hiding this comment

shubham1206agra May 15, 2024

Choose a reason for hiding this comment

shawnborton commented May 6, 2024

rushatgabhane commented May 6, 2024 • edited Loading

shubham1206agra commented May 10, 2024

rushatgabhane commented May 10, 2024

rushatgabhane commented May 13, 2024 • edited Loading

shawnborton commented May 13, 2024

rushatgabhane commented May 13, 2024 • edited Loading

1. Top line lineHeight: 16

2. Middle lineHeight: 20

3. Bottom line: lineHeight: 14px

4. Fixed the gap to be 4px.

rushatgabhane commented May 30, 2024 • edited Loading

stitesExpensify left a comment

Choose a reason for hiding this comment

shubham1206agra commented May 31, 2024

rushatgabhane commented May 31, 2024 • edited Loading

dannymcclain commented May 31, 2024

rushatgabhane commented Jun 2, 2024

stitesExpensify commented Jun 4, 2024

shawnborton commented Jun 4, 2024

stitesExpensify left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 4, 2024

OSBotify commented Jun 11, 2024

luacmartins Jul 18, 2024

Choose a reason for hiding this comment

shubham1206agra commented Aug 7, 2024

rushatgabhane commented May 6, 2024 •

edited

Loading

rushatgabhane commented May 6, 2024 •

edited

Loading

rushatgabhane commented May 13, 2024 •

edited

Loading

rushatgabhane commented May 13, 2024 •

edited

Loading

1. Top line `lineHeight: 16`

2. Middle `lineHeight: 20`

3. Bottom line: `lineHeight: 14px`

rushatgabhane commented May 30, 2024 •

edited

Loading

rushatgabhane commented May 31, 2024 •

edited

Loading