Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement offline behavior and error handling for UpdateGroupChatName #41826

Merged
merged 8 commits into from
May 28, 2024
Merged

Implement offline behavior and error handling for UpdateGroupChatName #41826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f7103a
feature: Implement offline behavior and error handling for UpdateGro…
nkdengineer May 8, 2024
084e45e
update logic update group chat name
nkdengineer May 13, 2024
b9a0c25
Update src/libs/actions/Report.ts
nkdengineer May 14, 2024
c91742f
add new error
nkdengineer May 14, 2024
a102435
fix: logic check is valid report name
nkdengineer May 14, 2024
02f9472
Update src/libs/actions/Report.ts
nkdengineer May 15, 2024
320cb6e
fix: update group name limit
nkdengineer May 15, 2024
3bf2763
Merge branch 'main' into fix/39984
nkdengineer May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,6 +1267,7 @@ export default {
lastMemberTitle: 'Heads up!',
lastMemberWarning: "Since you're the last person here, leaving will make this chat inaccessible to all users. Are you sure you want to leave?",
defaultReportName: ({displayName}: {displayName: string}) => `${displayName}'s group chat`,
invalidGroupChatName: 'Invalid group chat name',
},
languagePage: {
language: 'Language',
Expand Down
1 change: 1 addition & 0 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,6 +1266,7 @@ export default {
lastMemberTitle: '¡Atención!',
lastMemberWarning: 'Ya que eres la última persona aquí, si te vas, este chat quedará inaccesible para todos los usuarios. ¿Estás seguro de que quieres salir del chat?',
defaultReportName: ({displayName}: {displayName: string}) => `Chat de group de ${displayName}`,
invalidGroupChatName: 'Nombre de chat grupal no válido',
},
languagePage: {
language: 'Idioma',
Expand Down
29 changes: 27 additions & 2 deletions src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import {prepareDraftComment} from '@libs/DraftCommentUtils';
import * as EmojiUtils from '@libs/EmojiUtils';
import * as Environment from '@libs/Environment/Environment';
import * as ErrorUtils from '@libs/ErrorUtils';
import * as Localize from '@libs/Localize';
import Log from '@libs/Log';
import * as LoginUtils from '@libs/LoginUtils';
import Navigation from '@libs/Navigation/Navigation';
Expand Down Expand Up @@ -635,14 +636,38 @@ function updateGroupChatName(reportID: string, reportName: string) {
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: {
reportName,
errorFields: {
nkdengineer marked this conversation as resolved.
Show resolved Hide resolved
pendingFields: {
reportName: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
},
},
},
];

const successData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: {
pendingFields: {
reportName: null,
},
},
},
];
const failureData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: {
reportName: ReportUtils.getReport(reportID)?.reportName,
nkdengineer marked this conversation as resolved.
Show resolved Hide resolved
errors: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capturing error should be based on errorFields but since we depended on errors this resulted in issue #42765

reportName: Localize.translateLocal('groupChat.invalidGroupChatName'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB. I think we want to use a generic error message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's use the generic message as we already discussed here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s77rt @dukenv0307 i added new generic error, please check again

},
},
},
];
nkdengineer marked this conversation as resolved.
Show resolved Hide resolved
const parameters: UpdateGroupChatNameParams = {reportName, reportID};
API.write(WRITE_COMMANDS.UPDATE_GROUP_CHAT_NAME, parameters, {optimisticData});
API.write(WRITE_COMMANDS.UPDATE_GROUP_CHAT_NAME, parameters, {optimisticData, successData, failureData});
}

function updateGroupChatAvatar(reportID: string, file?: File | CustomRNImageManipulatorResult) {
Expand Down
Loading