Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing endless invoice room updates #41829

Merged
merged 4 commits into from
May 13, 2024
Merged

Fixing endless invoice room updates #41829

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c6ea57
fix native gesture behaviour
rezkiy37 May 7, 2024
04f5ce1
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 May 8, 2024
0a9b377
Update ReportActionsView to handle invoice rooms
rezkiy37 May 8, 2024
92312c1
Revert "fix native gesture behaviour"
rezkiy37 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pages/home/report/ReportActionsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,8 @@ function ReportActionsView({
reportActions.length >= 1 &&
!isLoadingInitialReportActions &&
!isLoadingOlderReportActions &&
!isLoadingNewerReportActions;
!isLoadingNewerReportActions &&
!ReportUtils.isInvoiceRoom(report);

if (shouldOpenReport) {
Report.openReport(reportID, reportActionID);
Expand All @@ -423,6 +424,7 @@ function ReportActionsView({
isLoadingOlderReportActions,
isLoadingNewerReportActions,
isLoadingInitialReportActions,
report,
]);

// Check if the first report action in the list is the one we're currently linked to
Expand Down
Loading