fix: Workspace - RBR is aligned to top of WS bar. #42017

Krishna2323 · 2024-05-11T05:05:09Z

Details

Fixed Issues

$ #41609
PROPOSAL: #41609 (comment)

Tests

Go to profile settings > troubleshoot > turn on Simulate failing network requests
Go to profile settings > workspaces > select a workspace > update few things until any error is shown
Go back to workspaces page > verify the RBR is aligned to centre in the row

Verify that no errors appear in the JS console

Offline tests

Go to profile settings > troubleshoot > turn on Simulate failing network requests
Go to profile settings > workspaces > select a workspace > update few things until any error is shown
Go back to workspaces page > verify the RBR is aligned to centre in the row

QA Steps

Go to profile settings > troubleshoot > turn on Simulate failing network requests
Go to profile settings > workspaces > select a workspace > update few things until any error is shown
Go back to workspaces page > verify the RBR is aligned to centre in the row

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-05-11T05:05:14Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2024-05-12T22:22:58Z

The RBR now looks right vertically but I always thought it was gonna be aligned to the right side of this row next to the ··· (overflow icon). It looks a bit floating in the middle here.

So my take would be anchoring it over to the right, but I'll let @Expensify/design chime in further

shawnborton · 2024-05-13T12:24:14Z

Yeah, I agree with Jon - I would think the RBR would be right next to the three dots icon with a 8-12px gap.

Krishna2323 · 2024-05-16T18:03:33Z

@dubielzyk-expensify @shawnborton, thoughts on this? IMO this looks weird.

shawnborton · 2024-05-16T18:05:49Z

Why isn't the RBR on the left side of the three dots? And we'd need to adjust the columns so that everything lines up even when there is the GBR there.

Krishna2323 · 2024-05-16T18:11:27Z

@shawnborton, I placed RBR to the right of three dots, I guess this is what we wanted according to this comment. IMO what we have currently looks good, because if we place the RBR on the right of three dots, the alignment will look weird or even if we align the three dots, the rows with now RBR will have extra margin right for no reason.

shawnborton · 2024-05-16T18:16:10Z

I think Jon means just to move the RBR closer to the three dots icon, much like we do for things like push rows:

Krishna2323 · 2024-05-16T18:18:19Z

Sorry for that, I totally misunderstood that.

shawnborton · 2024-05-16T18:19:03Z

All good!

Krishna2323 · 2024-05-16T18:31:54Z

@shawnborton, does this look correct, no margin right has been applied to RBR icon because the actual three dot icon width is 5px but the icon container takes 40px, so we already have 40px-5px/2=17.5px margin on both sides of three dot icon. If we need 12px or 8px we can apply negative margin right to RBR.

Monosnap (150) New Expensify 2024-05-16 23-58-02

shawnborton · 2024-05-16T18:40:26Z

I've always found it super weird that we gave the rows this kind of padding:

Where the right side has no padding, but left/top/bottom do. I think if you are open to it, we should:

just use a clean 20px of padding on each row
remove the 40px bounding box around the three dots icon, but increase the hit slop so we can increase the tappable area
place the RBR icon next to the three dots, and put a gap of 12px between the two

Thoughts on that approach?

Krishna2323 · 2024-05-17T11:13:33Z

@shawnborton, I removed the fixed width and height and tried to increase the pressable area by using hitSlop, but that doesn't seem to be working on the web. The pressable area remains the same as the width and height of the element. I guess thats why we have fixed width and height of 40px.

shawnborton · 2024-05-17T11:53:58Z

I think that's probably fine on web though?

Krishna2323 · 2024-05-20T08:27:51Z

@thesahindia @shawnborton, I'm not sure what we should do here. The three-dot menu is used on many pages, and removing the fixed width and height will also affect the margins of those pages. Should we remove the margin for this specific page (workspaces list page)?

shawnborton · 2024-05-20T13:51:44Z

Okay, so maybe we just leave that as-is, but:

let's add the 20px of padding to the entire workspace row on desktop
let's just make the red dot like 4-8px away from the three dots container

Can we move forward with that and see how it looks? Thanks!

Krishna2323 · 2024-05-20T14:04:47Z

@Expensify/design,

20px padding for list row & 4px gap between RBR and three dot icon:

20px padding for list row & 8px gap between RBR and three dot icon:

shawnborton · 2024-05-20T14:06:34Z

Nice! I like the first one (4px gap) the most, curious if others feel strongly. Thanks for sharing both mocks.

dannymcclain · 2024-05-20T14:30:34Z

Nice! I like the first one (4px gap) the most, curious if others feel strongly.

I like that one too.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-05-22T09:18:35Z

@thesahindia, you can start reviewing.

@Expensify/design, could you please confirm one last thing? There was no margin between the workspace name and RBR before. I have added 8px margin. Does that look correct? The reason for adding 8px is that the requested container also uses the same margin. You can see that in the screenshots below for the small width and the last workspace.

Small	Narrow	Full

dannymcclain · 2024-05-22T13:53:30Z

There was no margin between the workspace name and RBR before. I have added an 8px margin. Does that look correct? The reason for adding 8px is that the requested container also uses the same margin.

@Krishna2323 Yeah I think it makes sense to have that margin, so what you have does look correct to me.

shawnborton · 2024-05-22T17:52:38Z

Yup, I agree with that

thesahindia · 2024-05-23T14:29:50Z

@Krishna2323, please update the screenshots.

thesahindia · 2024-05-23T15:48:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

thesahindia

Looks good!

MonilBhavsar · 2024-05-24T12:11:30Z

Thanks Design team for the help here 🙇 Looking great

MonilBhavsar · 2024-05-24T12:11:59Z

We can let this out next week considering merge slush

OSBotify · 2024-05-29T04:53:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:42:36Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:25Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:23Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hungvu193 · 2024-07-17T03:21:43Z

src/pages/workspace/WorkspacesListRow.tsx

@@ -142,9 +142,9 @@ function WorkspacesListRow({
    const isDeleted = style && Array.isArray(style) ? style.includes(styles.offlineFeedback.deleted) : false;

    const ThreeDotMenuOrPendingIcon = (
-        <View style={[isNarrow && styles.mr5]}>
+        <View style={[styles.flexRow]}>


This is not really the culprit PR of #44639.
However if we don't add limit width here and with the flex1 style of Badge wrapper View, it will cause #44639.
More detail in this proposal RCA:
#44639 (comment)

fix: Workspace - RBR is aligned to top of WS bar.

8a0558b

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested review from a team as code owners May 11, 2024 05:05

melvin-bot bot requested review from thesahindia and removed request for a team May 11, 2024 05:05

Merge branch 'Expensify:main' into krishna2323/issue/41609

91c37a0

Krishna2323 added 3 commits May 22, 2024 14:25

fix: workspace list row padding.

1103541

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

remove margin from row items.

5d94e64

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

update margin left or RBR.

04016a4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

thesahindia approved these changes May 23, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar May 23, 2024 15:49

MonilBhavsar approved these changes May 24, 2024

View reviewed changes

MonilBhavsar merged commit e5ec7be into Expensify:main May 29, 2024
16 checks passed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

melvin-bot bot mentioned this pull request May 30, 2024

[HOLD for payment 2024-06-06] [$250] Workspace - RBR is aligned to top of WS bar #41609

Closed

6 tasks

hungvu193 reviewed Jul 17, 2024

View reviewed changes

hungvu193 mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-17] [$250] Android - Workspace - Workspace name is not displayed when navigate via join link #44639

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Workspace - RBR is aligned to top of WS bar. #42017

fix: Workspace - RBR is aligned to top of WS bar. #42017

Krishna2323 commented May 11, 2024 •

edited

Loading

melvin-bot bot commented May 11, 2024

dubielzyk-expensify commented May 12, 2024

shawnborton commented May 13, 2024

Krishna2323 commented May 16, 2024

shawnborton commented May 16, 2024

Krishna2323 commented May 16, 2024 •

edited

Loading

shawnborton commented May 16, 2024

Krishna2323 commented May 16, 2024

shawnborton commented May 16, 2024

Krishna2323 commented May 16, 2024

shawnborton commented May 16, 2024

Krishna2323 commented May 17, 2024

shawnborton commented May 17, 2024

Krishna2323 commented May 20, 2024

shawnborton commented May 20, 2024

Krishna2323 commented May 20, 2024

shawnborton commented May 20, 2024

dannymcclain commented May 20, 2024

Krishna2323 commented May 22, 2024 •

edited

Loading

dannymcclain commented May 22, 2024

shawnborton commented May 22, 2024

thesahindia commented May 23, 2024

thesahindia commented May 23, 2024

thesahindia left a comment

MonilBhavsar commented May 24, 2024

MonilBhavsar commented May 24, 2024

OSBotify commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

hungvu193 Jul 17, 2024

fix: Workspace - RBR is aligned to top of WS bar. #42017

fix: Workspace - RBR is aligned to top of WS bar. #42017

Conversation

Krishna2323 commented May 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 11, 2024

dubielzyk-expensify commented May 12, 2024

shawnborton commented May 13, 2024

Krishna2323 commented May 16, 2024

shawnborton commented May 16, 2024

Krishna2323 commented May 16, 2024 • edited Loading

shawnborton commented May 16, 2024

Krishna2323 commented May 16, 2024

shawnborton commented May 16, 2024

Krishna2323 commented May 16, 2024

shawnborton commented May 16, 2024

Krishna2323 commented May 17, 2024

shawnborton commented May 17, 2024

Krishna2323 commented May 20, 2024

shawnborton commented May 20, 2024

Krishna2323 commented May 20, 2024

20px padding for list row & 4px gap between RBR and three dot icon:

20px padding for list row & 8px gap between RBR and three dot icon:

shawnborton commented May 20, 2024

dannymcclain commented May 20, 2024

Krishna2323 commented May 22, 2024 • edited Loading

dannymcclain commented May 22, 2024

shawnborton commented May 22, 2024

thesahindia commented May 23, 2024

thesahindia commented May 23, 2024

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

MonilBhavsar commented May 24, 2024

MonilBhavsar commented May 24, 2024

OSBotify commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

hungvu193 Jul 17, 2024

Choose a reason for hiding this comment

Krishna2323 commented May 11, 2024 •

edited

Loading

Krishna2323 commented May 16, 2024 •

edited

Loading

Krishna2323 commented May 22, 2024 •

edited

Loading