fix: Workflows - Offline indicator is present below the last option instead of page bottom. #42019

Krishna2323 · 2024-05-11T16:58:40Z

Details

Fixed Issues

$ #41326
PROPOSAL: #41326 (comment)

Tests

On mWeb/native apps

Go offline
Go to Account settings > Workspaces > any workspace
Go to Workflows
Tap Submission frequency
Verify offline indicator is at the bottom of the screen

On web/desktop app

Go to Account settings > Workspaces > any workspace
Go to Workflows
Tap Submission frequency
Verify arrow key navigation works to focus and select any option

Verify that no errors appear in the JS console

Offline tests

On mWeb/native apps

Go offline
Go to Account settings > Workspaces > any workspace
Go to Workflows
Tap Submission frequency
Verify offline indicator is at the bottom of the screen

On web/desktop app

Go to Account settings > Workspaces > any workspace
Go to Workflows
Tap Submission frequency
Verify arrow key navigation works to focus and select any option

QA Steps

On mWeb/native apps

Go offline
Go to Account settings > Workspaces > any workspace
Go to Workflows
Tap Submission frequency
Verify offline indicator is at the bottom of the screen

On web/desktop app

Go to Account settings > Workspaces > any workspace
Go to Workflows
Tap Submission frequency
Verify arrow key navigation works to focus and select any option

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…nstead of page bottom. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-05-11T16:58:45Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

hoangzinh

Sorry for late review. Overall looks good, just some feedbacks

hoangzinh · 2024-05-16T00:30:04Z

src/hooks/useArrowKeyFocusManager.ts

+    useEffect(() => {
+        setFocusedIndex(initialFocusedIndex);
+    }, [initialFocusedIndex]);
+


why do we need this change @Krishna2323?

There was a focus issue with the newly selected option. Although I don't completely remember the exact bug. I removed this code as I can't reproduce any bug like that.

hoangzinh · 2024-05-16T00:32:23Z

src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx

-            {isMonthlyFrequency && item.keyForList === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MONTHLY ? monthlyFrequencyDetails() : null}
-        </>
-    );
+    const autoReportingFrequencyItems: WorkspaceAutoReportingFrequencyPageItem[] = Object.keys(getAutoReportingFrequencyDisplayNames(preferredLocale)).map((frequencyKey) => {


we can put it into a memo to memorize this output

I don't think this is necessary, but if we decide to use memo, we would also need to wrap monthlyFrequencyDetails and getDescriptionText in useCallback.

uhm, let's keep it as it's

hoangzinh · 2024-05-16T00:44:20Z

src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx

+            text: getAutoReportingFrequencyDisplayNames(preferredLocale)[frequencyKey as AutoReportingFrequencyKey] || '',
+            keyForList: frequencyKey,
+            isSelected,
+            footerComponent: isMonthlyFrequency && frequencyKey === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MONTHLY ? monthlyFrequencyDetails() : null,


Suggested change

footerComponent: isMonthlyFrequency && frequencyKey === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MONTHLY ? monthlyFrequencyDetails() : null,

FooterComponent: isMonthlyFrequency && frequencyKey === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MONTHLY ? monthlyFrequencyDetails() : null,

If it's a component we should name it capitalize

@hoangzinh, we use camelCase for components as well, and instead of component we use content, so I replaced footerComponent with footerContent.

It doesn't show footerContent when I select "Monthly" option. Could you take a look?

Screen.Recording.2024-05-21.at.22.23.44.mov

@hoangzinh, maybe you don't have access, I just removed that check for testing.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 53 in e8ae3c5

const canUseDelayedSubmission = Permissions.canUseWorkflowsDelayedSubmission(betas);

No I mean the extra option "Date of month" when user selects "Monthly" option. Can you retest it and record your screen if you can see that "Date of month" option when you select "Monthly" option? Thanks

hmm, sorry there was a typo, I forgot to update footerComponent to footerContent in one place. Fixed now.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

hoangzinh · 2024-05-23T15:12:17Z

Hi @Krishna2323 in your test cases, I think instead of "For devices with width <800" we can say "On mWeb/native apps"

hoangzinh · 2024-05-23T15:45:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-23.at.22.29.57.android.mov

Android: mWeb Chrome

Screen.Recording.2024-05-23.at.22.31.32.android.chrome.mov

iOS: Native

Screen.Recording.2024-05-23.at.22.26.13.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-05-23.at.22.23.43.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-23.at.22.12.35.web.mov

MacOS: Desktop

Screen.Recording.2024-05-23.at.22.13.34.desktop.mov

hoangzinh

LGTM

melvin-bot · 2024-05-24T04:57:26Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #41326 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

hoangzinh · 2024-05-24T05:02:00Z

Oops, PR has conflict, can you help resolve it? @Krishna2323

…a2323/issue/41326

Krishna2323 · 2024-05-24T18:48:06Z

Conflicts resolved.

hoangzinh

LGTM

puneetlath · 2024-05-27T21:15:10Z

Looks good to me, but you've got conflicts now.

…a2323/issue/41326

Krishna2323 · 2024-05-28T00:30:04Z

@puneetlath, conflicts resolved.

Krishna2323 · 2024-05-29T15:09:50Z

@puneetlath, friendly bump to merge this.

puneetlath

Sorry for the delay. Lots going on. One comment.

puneetlath · 2024-05-30T15:08:10Z

src/components/SelectionList/BaseSelectionList.tsx

@@ -427,7 +427,8 @@ function BaseSelectionList<TItem extends ListItem>(
                    shouldPreventDefaultFocusOnSelectRow={shouldPreventDefaultFocusOnSelectRow}
                    // We're already handling the Enter key press in the useKeyboardShortcut hook, so we don't want the list item to submit the form
                    shouldPreventEnterKeySubmit
-                    rightHandSideComponent={rightHandSideComponent}
+                    // Change this because of lint


Can we leave a better comment here? I'm not sure what this means.

@puneetlath, we haven't changed or added any prop to ListItem, we only wrapped it with <></> and added {item.footerContent && item.footerContent} below it

Yeah, makes sense. But since we're touching this code, let's still make this comment better while we're here. To leave the code in a better place than when we found it.

Merged main and that part is removed now.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

OSBotify · 2024-05-31T01:16:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: Workflows - Offline indicator is present below the last option instead of page bottom.

ZhenjaHorbach · 2024-09-06T18:57:10Z

src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx

-                            data={autoReportingFrequencyItems}
-                            renderItem={renderItem}
-                            keyExtractor={(item: WorkspaceAutoReportingFrequencyPageItem) => item.text}
+                        <SelectionList


Coming from this #47574
Since we don't pass shouldUpdateFocusedIndex we don't see selected background after selecting Submission frequency as monthly

fix: Workflows - Offline indicator is present below the last option i…

422ba55

…nstead of page bottom. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner May 11, 2024 16:58

melvin-bot bot removed the request for review from a team May 11, 2024 16:58

melvin-bot bot requested a review from hoangzinh May 11, 2024 16:58

Krishna2323 added 3 commits May 11, 2024 22:32

minor update.

6ddaad4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

47abac3

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

update focus index when initialFocusedIndex changes.

ce82f83

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

hoangzinh reviewed May 16, 2024

View reviewed changes

Krishna2323 added 4 commits May 17, 2024 16:52

Merge branch 'Expensify:main' into krishna2323/issue/41326

5ebd6d9

remove redundant code.

9350a31

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

rename footerComponent to footerContent.

2cbeb45

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

fix typo.

df2b6b7

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

hoangzinh approved these changes May 24, 2024

View reviewed changes

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

0be8338

…a2323/issue/41326

hoangzinh approved these changes May 25, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath May 25, 2024 03:35

puneetlath previously approved these changes May 27, 2024

View reviewed changes

Krishna2323 added 2 commits May 28, 2024 05:56

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

b565f2c

…a2323/issue/41326

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

8106011

…a2323/issue/41326

Krishna2323 dismissed puneetlath’s stale review via 8106011 May 28, 2024 00:27

Merge branch 'main' into krishna2323/issue/41326

f5e5f49

puneetlath requested changes May 30, 2024

View reviewed changes

Krishna2323 added 3 commits May 31, 2024 03:53

Merge branch 'main' into krishna2323/issue/41326

9e8e01b

remove extra line break.

0f58c9a

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/41326

cf0be8a

puneetlath approved these changes May 31, 2024

View reviewed changes

puneetlath merged commit 5699ae3 into Expensify:main May 31, 2024
15 checks passed

hayata-suenaga pushed a commit that referenced this pull request May 31, 2024

Merge pull request #42019 from Krishna2323/krishna2323/issue/41326

2e061e7

fix: Workflows - Offline indicator is present below the last option instead of page bottom.

melvin-bot bot mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-06-13] [$250] Workflows - Offline indicator is present below the last option instead of page bottom #41326

Closed

6 tasks

ZhenjaHorbach reviewed Sep 6, 2024

View reviewed changes

ZhenjaHorbach mentioned this pull request Sep 6, 2024

[HOLD for payment 2024-09-06] [$250] There is no selected background after selecting Submission frequency as monthly #47574

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Workflows - Offline indicator is present below the last option instead of page bottom. #42019

fix: Workflows - Offline indicator is present below the last option instead of page bottom. #42019

Krishna2323 commented May 11, 2024 •

edited

Loading

melvin-bot bot commented May 11, 2024

hoangzinh left a comment

hoangzinh May 16, 2024

Krishna2323 May 20, 2024

hoangzinh May 16, 2024

Krishna2323 May 20, 2024

hoangzinh May 20, 2024

hoangzinh May 16, 2024

Krishna2323 May 20, 2024

hoangzinh May 21, 2024

Krishna2323 May 22, 2024

hoangzinh May 22, 2024

Krishna2323 May 22, 2024

hoangzinh commented May 23, 2024

hoangzinh commented May 23, 2024 •

edited

Loading

hoangzinh left a comment

melvin-bot bot commented May 24, 2024

hoangzinh commented May 24, 2024

Krishna2323 commented May 24, 2024

hoangzinh left a comment

puneetlath commented May 27, 2024

Krishna2323 commented May 28, 2024

Krishna2323 commented May 29, 2024

puneetlath left a comment

puneetlath May 30, 2024

Krishna2323 May 30, 2024

puneetlath May 30, 2024

Krishna2323 May 30, 2024

OSBotify commented May 31, 2024

ZhenjaHorbach Sep 6, 2024

	footerComponent: isMonthlyFrequency && frequencyKey === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MONTHLY ? monthlyFrequencyDetails() : null,
	FooterComponent: isMonthlyFrequency && frequencyKey === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MONTHLY ? monthlyFrequencyDetails() : null,

fix: Workflows - Offline indicator is present below the last option instead of page bottom. #42019

fix: Workflows - Offline indicator is present below the last option instead of page bottom. #42019

Conversation

Krishna2323 commented May 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 11, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented May 23, 2024

hoangzinh commented May 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 24, 2024

hoangzinh commented May 24, 2024

Krishna2323 commented May 24, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

puneetlath commented May 27, 2024

Krishna2323 commented May 28, 2024

Krishna2323 commented May 29, 2024

puneetlath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented May 31, 2024

Choose a reason for hiding this comment

Krishna2323 commented May 11, 2024 •

edited

Loading

hoangzinh commented May 23, 2024 •

edited

Loading