fix: Status - Emoji in custom status holder is not centered. #42032

Krishna2323 · 2024-05-13T04:03:23Z

Details

Fixed Issues

$ #35389
PROPOSAL: #35389 (comment)

Tests

Go to Settings > Profile > Status
Select a square emoji and save it
Return to home page
Zoom in the emoji on profile tab and verify it is centered

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Profile > Status
Select a square emoji and save it
Return to home page
Zoom in the emoji on profile tab and verify it is centered

QA Steps

Go to Settings > Profile > Status
Select a square emoji and save it
Return to home page
Zoom in the emoji on profile tab and verify it is centered

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Chrome:
https://github.com/Expensify/App/assets/85894871/aea29909-8dd4-43b0-ad97-d924f58e0e37

Safari
https://github.com/Expensify/App/assets/85894871/2a45063a-4d0a-46cd-b420-3533629fe3ce

MacOS: Desktop

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-05-13T04:03:28Z

@dubielzyk-expensify @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

dubielzyk-expensify · 2024-05-13T08:32:44Z

I see that this is draft, but would be good with some screenshots for my design review when you're ready 👍 Thanks!

Krishna2323 · 2024-05-13T08:43:06Z

@dubielzyk-expensify, recordings of web safari and chrome

Chrome

web_chrome.mp4

Safari

web_safari.mp4

dubielzyk-expensify · 2024-05-13T09:55:19Z

Was hard to see but tested it locally from the branch and it looks mostly good except that it's 1px too far to the right:

shawnborton · 2024-05-13T11:43:19Z

Nice 🦅 👁️ Jon!

shawnborton · 2024-05-13T11:44:00Z

src/styles/index.ts

+                !Browser.isMobile() && {
+                    transform: 'scale(0.65)',
+                    fontSize: 13,
+                    lineHeight: 15,


What happens if we use 16 instead?

I will try that and let you know in a few hours. Can you please let me know what's your expectation is by doing that? Is there a problem with lineHeight: 15?

We just typically try to keep things at base4 for our sizes (12, 16, 20, etc)

Krishna2323 · 2024-05-15T14:52:34Z

@dubielzyk-expensify, thanks for the review. I guess the screenshots you provided are from Chrome and are not zoomed in, is that correct? I just wanted to confirm before I try to find a solution for that, because when zoomed in, it's correctly centered for me on both Safari and Chrome. Sorry for the late reply, I'm not at my workplace.

dubielzyk-expensify · 2024-05-15T22:58:30Z

Correct. It's on Chrome taken with 100% so no zoom

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

…323/App into krishna2323/issue/35389

Krishna2323 · 2024-05-21T11:05:44Z

@dubielzyk-expensify, can you pls retest this PR. I increased the emoji size a bit and now it is correctly centered.

On Chrome taken with 100%

dubielzyk-expensify · 2024-05-22T06:13:22Z

That looks good to me. The 🟥 seems to overstep its boundries by less than a pixel. Thoughts on this @shawnborton ? Should we overflow: hidden, size it down again, or ship like this. I think the only emojis that'll go out of bounds will be 📆 and 🟥 as they are weirdly bigger than the rest

Krishna2323 · 2024-05-22T06:15:49Z

@dubielzyk-expensify, yep, thats the only issue, we can also increase the container width and height by 2 px, currently its 20px.

shawnborton · 2024-05-22T17:55:50Z

I don't think we need to change the container size or adjust the emoji size. I'd be fine leaving as-is, or adding the overflow-hidden like you are suggesting.

dubielzyk-expensify · 2024-05-23T01:45:43Z

I'd be fine leaving as-is, or adding the overflow-hidden like you are suggesting.

@Krishna2323 : Let's add overflow hidden then and get this shipped 😄

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-05-24T16:23:35Z

@abdulrahuman5196, you can start reviewing.

@dubielzyk-expensify @shawnborton,

Overflow hidden

Overflow visible

shawnborton · 2024-05-24T16:33:20Z

No strong feelings from me, either one works!

dubielzyk-expensify · 2024-05-26T23:11:36Z

Let's go with overflow: hidden to ensure we don't end up with any weird issues if something were to spill over.

Krishna2323 · 2024-05-27T15:36:51Z

@abdulrahuman5196, friendly bump for review.

abdulrahuman5196 · 2024-05-28T18:27:15Z

Hi, I will check on this review tomorrow, I am assuming design team is fine with the current path.

shawnborton · 2024-05-28T18:28:35Z

Yup, sounds like we landed on overflow: hidden

abdulrahuman5196 · 2024-06-03T17:21:14Z

Checking now

abdulrahuman5196 · 2024-06-03T19:11:44Z

I checked all platforms expect android chrome. Facing site issues. Will check back again in morning and close this out.

abdulrahuman5196 · 2024-06-04T09:20:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-03.at.11.32.02.PM.mp4

Android: mWeb Chrome

Screen.Recording.2024-06-04.at.2.45.01.PM.mp4

iOS: Native

Screen.Recording.2024-06-03.at.11.24.16.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-06-03.at.11.29.25.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-06-03.at.11.18.02.PM.mp4

MacOS: Desktop

Screen.Recording.2024-06-03.at.11.21.12.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @dubielzyk-expensify / @madmax330

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-06-10T08:24:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T22:27:50Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.4.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-13T15:30:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Status - Emoji in custom status holder is not centered.

9f0585e

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested review from a team as code owners May 13, 2024 04:03

melvin-bot bot requested review from abdulrahuman5196 and dubielzyk-expensify and removed request for a team May 13, 2024 04:03

Krishna2323 marked this pull request as draft May 13, 2024 04:03

remove redundant code.

f06518e

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review May 13, 2024 09:07

shawnborton reviewed May 13, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/35389

8180bac

Krishna2323 added 3 commits May 21, 2024 15:00

Merge branch 'Expensify:main' into krishna2323/issue/35389

526fa5d

aligm status emoji to center.

90ea13b

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'krishna2323/issue/35389' of https://github.com/Krishna2…

ec1af9b

…323/App into krishna2323/issue/35389

hide overflowing emoji from emoji status container.

6454fe2

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

dubielzyk-expensify approved these changes May 28, 2024

View reviewed changes

abdulrahuman5196 approved these changes Jun 4, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 June 4, 2024 09:26

madmax330 approved these changes Jun 10, 2024

View reviewed changes

madmax330 merged commit bb10b8b into Expensify:main Jun 10, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request Jun 11, 2024

Deploy Checklist: New Expensify 2024-06-11 #43515

Closed

59 tasks

melvin-bot bot mentioned this pull request Jun 13, 2024

[HOLD for payment 2024-06-20] [$500] Status - Emoji in custom status holder is not centered #35389

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Status - Emoji in custom status holder is not centered. #42032

fix: Status - Emoji in custom status holder is not centered. #42032

Krishna2323 commented May 13, 2024 •

edited

Loading

melvin-bot bot commented May 13, 2024

dubielzyk-expensify commented May 13, 2024

Krishna2323 commented May 13, 2024

dubielzyk-expensify commented May 13, 2024

shawnborton commented May 13, 2024

shawnborton May 13, 2024

Krishna2323 May 15, 2024

shawnborton May 15, 2024

Krishna2323 commented May 15, 2024

dubielzyk-expensify commented May 15, 2024

Krishna2323 commented May 21, 2024

dubielzyk-expensify commented May 22, 2024

Krishna2323 commented May 22, 2024

shawnborton commented May 22, 2024

dubielzyk-expensify commented May 23, 2024

Krishna2323 commented May 24, 2024

shawnborton commented May 24, 2024

dubielzyk-expensify commented May 26, 2024

Krishna2323 commented May 27, 2024

abdulrahuman5196 commented May 28, 2024

shawnborton commented May 28, 2024

abdulrahuman5196 commented Jun 3, 2024

abdulrahuman5196 commented Jun 3, 2024

abdulrahuman5196 commented Jun 4, 2024 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Jun 10, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024

fix: Status - Emoji in custom status holder is not centered. #42032

fix: Status - Emoji in custom status holder is not centered. #42032

Conversation

Krishna2323 commented May 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 13, 2024

dubielzyk-expensify commented May 13, 2024

Krishna2323 commented May 13, 2024

Chrome

Safari

dubielzyk-expensify commented May 13, 2024

shawnborton commented May 13, 2024

shawnborton May 13, 2024

Choose a reason for hiding this comment

Krishna2323 May 15, 2024

Choose a reason for hiding this comment

shawnborton May 15, 2024

Choose a reason for hiding this comment

Krishna2323 commented May 15, 2024

dubielzyk-expensify commented May 15, 2024

Krishna2323 commented May 21, 2024

On Chrome taken with 100%

dubielzyk-expensify commented May 22, 2024

Krishna2323 commented May 22, 2024

shawnborton commented May 22, 2024

dubielzyk-expensify commented May 23, 2024

Krishna2323 commented May 24, 2024

Overflow hidden

Overflow visible

shawnborton commented May 24, 2024

dubielzyk-expensify commented May 26, 2024

Krishna2323 commented May 27, 2024

abdulrahuman5196 commented May 28, 2024

shawnborton commented May 28, 2024

abdulrahuman5196 commented Jun 3, 2024

abdulrahuman5196 commented Jun 3, 2024

abdulrahuman5196 commented Jun 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 10, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024

Krishna2323 commented May 13, 2024 •

edited

Loading

abdulrahuman5196 commented Jun 4, 2024 •

edited

Loading