[No QA] do not skip workflow on main branch #42134

badeggg · 2024-05-14T09:06:28Z

Details

Fixed Issues

$ #41936
PROPOSAL: #41936 (comment)

Tests

Code change in this pr doesn't have any direct influence to Expensify App, it only effect github actions. We can not test this pr before it's merged to main ---- paradox. We can test the core change in a hack repo.
Start a hack repo
Within the repo, create a workflow file which has concurrency config like in this pr, set a time consuming job(e.g. a timeout). Example file content:

# .github/workflows/hack-41936.yml
name: Lint code

on:
  workflow_call:
  push:
  

concurrency:
  # core line
  group: ${{ github.ref == 'refs/heads/main' && format('{0}-{1}', github.ref, github.sha) || github.ref }}-lint
  cancel-in-progress: true

jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
    - name: date
      run: date

    # set a wait time to be easy to simulate concurrency situation
    - name: Wait for 120 seconds
      run: sleep 120s

Commit the change and push it to main branch.
On main branch, rapidly create new commit and push it.
Check the workflow run status for main branch, notice that all workflow runs(no skip)
Checkout a non-main branch, rapidly create new commit and push it.
Check the workflow run status for non-main branch, notice that former workflow run is cancelled.

Offline tests

N/A

QA Steps

Sam as Tests section

PR Author Checklist

Screenshots/Videos

melvin-bot · 2024-05-14T09:06:34Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-05-14T09:06:41Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

badeggg · 2024-05-14T09:11:36Z

I have read the CLA Document and I hereby sign the CLA

badeggg · 2024-05-14T09:11:49Z

recheck

rayane-djouah

Lets re-add cancel option with this fix in .github/workflows/e2ePerformanceTests.yml. it was removed in https://github.com/Expensify/App/pull/38399/files

rayane-djouah

Lets add concurrency option in typecheck.yml also

badeggg · 2024-05-14T14:35:37Z

Sure, totally agree. I will do this in my tomorrow morning.

badeggg · 2024-05-14T22:20:34Z

Also added concurrency config to typecheck.yml and e2ePerformanceTests.yml

rayane-djouah

Please add [No QA] prefix to the title of the PR

rayane-djouah · 2024-05-16T18:54:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2024-05-16.at.7.41.17.PM.mov

rayane-djouah

Thank you!
Changes look good and test well. The reviewer checklist is also complete.
🎀👀🎀 C+ reviewed

blimpich · 2024-05-16T19:14:06Z

Looks good. Will approve and merge once merge freeze is over.

blimpich

Approving, currently in a merge slush, meaning we are merging PRs based on whether they are low risk. I consider this low risk so I'll try to get this in

OSBotify · 2024-05-27T17:30:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:43:00Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:49Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: 41936, do not skip workflow on main branch

94b2046

badeggg requested a review from a team as a code owner May 14, 2024 09:06

melvin-bot bot requested review from rayane-djouah and removed request for a team May 14, 2024 09:06

rayane-djouah suggested changes May 14, 2024

View reviewed changes

add concurrency config to typecheck.yml and e2ePerformanceTests.yml

54a22fa

rayane-djouah suggested changes May 16, 2024

View reviewed changes

rayane-djouah approved these changes May 16, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich May 16, 2024 19:01

badeggg changed the title ~~do not skip workflow on main branch~~ [No QA] do not skip workflow on main branch May 16, 2024

blimpich approved these changes May 23, 2024

View reviewed changes

puneetlath merged commit 6c9421f into Expensify:main May 27, 2024
11 of 12 checks passed

blimpich mentioned this pull request May 27, 2024

[HOLD for payment 2024-06-06] [$250] preDeploy.yml should not skip on default branch if another run is queued #41936

Closed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] do not skip workflow on main branch #42134

[No QA] do not skip workflow on main branch #42134

badeggg commented May 14, 2024

melvin-bot bot commented May 14, 2024

github-actions bot commented May 14, 2024 •

edited

Loading

badeggg commented May 14, 2024

badeggg commented May 14, 2024

rayane-djouah left a comment

rayane-djouah left a comment

badeggg commented May 14, 2024

badeggg commented May 14, 2024

rayane-djouah left a comment

rayane-djouah commented May 16, 2024

rayane-djouah left a comment

blimpich commented May 16, 2024

blimpich left a comment

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

[No QA] do not skip workflow on main branch #42134

[No QA] do not skip workflow on main branch #42134

Conversation

badeggg commented May 14, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 14, 2024

github-actions bot commented May 14, 2024 • edited Loading

badeggg commented May 14, 2024

badeggg commented May 14, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

rayane-djouah left a comment

Choose a reason for hiding this comment

badeggg commented May 14, 2024

badeggg commented May 14, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

rayane-djouah commented May 16, 2024

Reviewer Checklist

Screenshots/Videos

rayane-djouah left a comment

Choose a reason for hiding this comment

blimpich commented May 16, 2024

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

github-actions bot commented May 14, 2024 •

edited

Loading