Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide empty group chats #42234

Merged
merged 3 commits into from
May 24, 2024
Merged

Don't hide empty group chats #42234

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a2885b
Dont hide group chats
srikarparsi May 15, 2024
f15c434
optimistic
srikarparsi May 21, 2024
b8c8d57
use undefined since default is ALWAYS
srikarparsi May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4373,7 +4373,7 @@ function buildOptimisticGroupChatReport(participantAccountIDs: number[], reportN
undefined,
undefined,
undefined,
CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
srikarparsi marked this conversation as resolved.
Show resolved Hide resolved
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -5181,7 +5181,7 @@ function shouldReportBeInOptionList({
}

// Hide chats between two users that haven't been commented on from the LNH
if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report) && canHideReport) {
if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report) && !isGroupChat(report) && canHideReport) {
Copy link
Contributor

@marcaaron marcaaron May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this in the BE? They are only hidden because we set them to 'hidden' when someone creates one.

return false;
}

Expand Down
Loading