-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text attachment edit comment bug #42290
Fix text attachment edit comment bug #42290
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Native42290.Android.mp4Android: mWeb Chrome42290.mWeb-Chrome.mp4iOS: Native42290.iOS.moviOS: mWeb Safari42290.mWeb-Safari.movMacOS: Chrome / Safari42290.Web.mp4MacOS: Desktop42290.Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@FitseTLT Could you pull the latest main so the typecheck pass? Thanks!
Tests Passed 👍 |
We can merge this once the merge freeze is lifted |
@MariaHCD Isn't the merge freeze lifted yet? |
The merge freeze is not completely lifted yet. Requesting this week's App deployer to review this. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.76-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀
|
Details
Fixed Issues
$ #40400
PROPOSAL: #40400 (comment)
Tests
Edit comment
is not included in the context menu listEdit comment
menu exists and press on itOffline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Untitled.Project.mp4
a2.mp4
Android: mWeb Chrome
a.w.mp4
iOS: Native
iOS: mWeb Safari
i.w.mp4
MacOS: Chrome / Safari
w.mp4
MacOS: Desktop
d.mp4