Fix can't interact with deleted parent action after deleting it for a while #42341

bernhardoj · 2024-05-17T11:47:48Z

Details

A pending deleted message will have a pointer events set to none, but for deleted parent action, we still want the user to interact with it, for example, pressing the reply button.

Fixed Issues

$ #42194
PROPOSAL: #42194 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Send 2 messages in any chat
Reply to the thread on the message 1
Go offline
Delete both messages
Verify you can press the "N Replies" button of message 1
Verify the 2nd message isn't interactable (for example, no hover background)
Go online
The message 1 will change to [Deleted message]
Verify you can press the "N Replies" button immediately

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-17.at.19.39.17.mov

Android: mWeb Chrome

Screen.Recording.2024-05-17.at.19.35.24.mov

iOS: Native

Screen.Recording.2024-05-17.at.19.24.08.mov

iOS: mWeb Safari

Screen.Recording.2024-05-17.at.19.28.55.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-17.at.19.19.24.mov

Screen.Recording.2024-05-17.at.19.20.03.mov

MacOS: Desktop

Screen.Recording.2024-05-17.at.19.21.02.mov

melvin-bot · 2024-05-17T11:47:54Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-05-17T11:49:56Z

src/pages/home/report/ReportActionItem.tsx

@@ -933,7 +933,7 @@ function ReportActionItem({
        <PressableWithSecondaryInteraction
            ref={popoverAnchorRef}
            onPress={draftMessage === undefined ? onPress : undefined}
-            style={[action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? styles.pointerEventsNone : styles.pointerEventsAuto]}
+            style={[action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !isDeletedParentAction ? styles.pointerEventsNone : styles.pointerEventsAuto]}


I see that we also have isDeletedParentAction

App/src/libs/ReportActionsUtils.ts

Lines 115 to 117 in e8ae3c5

function isDeletedParentAction(reportAction: OnyxEntry<ReportAction>): boolean {

return (reportAction?.message?.[0]?.isDeletedParentAction ?? false) && (reportAction?.childVisibleActionCount ?? 0) > 0;

}

which is very similar to isMessageDeleted.

App/src/libs/ReportActionsUtils.ts

Lines 804 to 806 in e8ae3c5

function isMessageDeleted(reportAction: OnyxEntry<ReportAction>): boolean {

return reportAction?.message?.[0]?.isDeletedParentAction ?? false;

}

I decided to use isDeletedParentAction instead which is already defined at the top of the component.

Ollyws · 2024-05-21T14:12:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

Julesssss · 2024-05-30T12:57:04Z

Hey @bernhardoj would you mind merging main again please?

…-while-offline

bernhardoj · 2024-05-30T13:40:00Z

@Julesssss done

github-actions · 2024-05-30T14:18:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42341/NewExpensify.dmg	https://42341.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2024-06-11T08:39:46Z

Sorry @bernhardoj I completely forgot about this. COuld you merge main once more and I'll merge, thanks

…-while-offline

bernhardoj · 2024-06-11T08:41:32Z

@Julesssss done

OSBotify · 2024-06-11T09:01:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T22:27:59Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-13T15:30:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

don't set pointer events to none for deleted parent action

6b33432

bernhardoj requested a review from a team as a code owner May 17, 2024 11:47

melvin-bot bot requested review from Ollyws and removed request for a team May 17, 2024 11:47

bernhardoj commented May 17, 2024

View reviewed changes

Ollyws approved these changes May 21, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote May 21, 2024 14:13

lakchote approved these changes May 21, 2024

View reviewed changes

Julesssss approved these changes May 22, 2024

View reviewed changes

Merge branch 'main' into fix/42194-dont-disable-deleted-parent-action…

ba1b41b

…-while-offline

Julesssss added the Ready To Build label May 30, 2024

Merge branch 'main' into fix/42194-dont-disable-deleted-parent-action…

bd69493

…-while-offline

Julesssss approved these changes Jun 11, 2024

View reviewed changes

Julesssss merged commit 2282810 into Expensify:main Jun 11, 2024
15 checks passed

github-actions bot mentioned this pull request Jun 11, 2024

Deploy Checklist: New Expensify 2024-06-11 #43515

Closed

59 tasks

melvin-bot bot mentioned this pull request Jun 13, 2024

[HOLD for payment 2024-06-20] [$250] Delay in Accessing Thread After Deleting Parent Message Offline #42194

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix can't interact with deleted parent action after deleting it for a while #42341

Fix can't interact with deleted parent action after deleting it for a while #42341

bernhardoj commented May 17, 2024

melvin-bot bot commented May 17, 2024

bernhardoj May 17, 2024

Ollyws commented May 21, 2024

Ollyws left a comment

Julesssss commented May 30, 2024

bernhardoj commented May 30, 2024

github-actions bot commented May 30, 2024

Julesssss commented Jun 11, 2024

bernhardoj commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024

	function isDeletedParentAction(reportAction: OnyxEntry<ReportAction>): boolean {
	return (reportAction?.message?.[0]?.isDeletedParentAction ?? false) && (reportAction?.childVisibleActionCount ?? 0) > 0;
	}

	function isMessageDeleted(reportAction: OnyxEntry<ReportAction>): boolean {
	return reportAction?.message?.[0]?.isDeletedParentAction ?? false;
	}

Fix can't interact with deleted parent action after deleting it for a while #42341

Fix can't interact with deleted parent action after deleting it for a while #42341

Conversation

bernhardoj commented May 17, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 17, 2024

bernhardoj May 17, 2024

Choose a reason for hiding this comment

Ollyws commented May 21, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

Julesssss commented May 30, 2024

bernhardoj commented May 30, 2024

github-actions bot commented May 30, 2024

Julesssss commented Jun 11, 2024

bernhardoj commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024