Fix linked message visibility in offline mode #42396

narefyev91 · 2024-05-20T16:02:18Z

Details

Linked message in report is not showing in offline mode and user stuck in the same screen without option to go back

Fixed Issues

$ #41063
PROPOSAL:

Tests

Launch New Expensify app.
Go offline.
Submit two expenses to a user.
Go to expense report.
Right click on any expense preview > Copy link.
Paste the link and send it.
Click on the same link
Verify that you can see messages - and linked message will be highlighted
Verify that user can go back and not stuck on the same screen (actual result in linked issue)

Verify that no errors appear in the JS console

Offline tests

Launch New Expensify app.
Go offline.
Submit two expenses to a user.
Go to expense report.
Right click on any expense preview > Copy link.
Paste the link and send it.
Click on the same link
Verify that you can see messages - and linked message will be highlighted
Verify that user can go back and not stuck on the same screen (actual result in linked issue)

QA Steps

Launch New Expensify app.
Go offline.
Submit two expenses to a user.
Go to expense report.
Right click on any expense preview > Copy link.
Paste the link and send it.
Click on the same link
Verify that you can see messages - and linked message will be highlighted
Verify that user can go back and not stuck on the same screen (actual result in linked issue)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-05-21T14:28:57Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-05-22T05:30:32Z

@narefyev91 Can you reproduce the original issue (User is stuck on the same page)? When I click on the link, I just see the empty screen. Is it what you fixed in this issue? Thanks

narefyev91 · 2024-05-22T06:39:42Z

@narefyev91 Can you reproduce the original issue (User is stuck on the same page)? When I click on the link, I just see the empty screen. Is it what you fixed in this issue? Thanks

Yeah - original issue was fixed by some earlier code, but a situation started to be like you describe - user just sees empty screen. Probably opening linking message in offline was missed during refactoring ReportActionView and introducing pagination

dukenv0307 · 2024-05-22T07:13:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-23.at.10.53.12.mov

Android: mWeb Chrome

web-resize.mp4

iOS: Native

Screen.Recording.2024-05-23.at.10.54.14.mov

iOS: mWeb Safari

web-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

web-resize.mp4

dukenv0307 · 2024-05-22T07:22:34Z

@narefyev91 After pressing the link, I saw the error There was an error loading more messages. It doesn't make more sense to me since I don't want to load the newest messages. Can you confirm if it's the expectation?

narefyev91 · 2024-05-22T08:06:19Z

@narefyev91 After pressing the link, I saw the error There was an error loading more messages. It doesn't make more sense to me since I don't want to load the newest messages. Can you confirm if it's the expectation?

Yeah good point - we should not see that message - let me double check!

narefyev91 · 2024-05-22T08:14:13Z

@dukenv0307 updated!

src/pages/home/report/ReportActionsView.tsx

dukenv0307 · 2024-05-23T03:56:52Z

Code looks good and tests well. Just left one minor suggestion. @narefyev91

narefyev91 · 2024-05-23T07:41:11Z

Code looks good and tests well. Just left one minor suggestion. @narefyev91

updated thanks!

melvin-bot · 2024-05-24T03:42:35Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #41063 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

dukenv0307 · 2024-05-24T03:45:00Z

@MariaHCD As you got assigned on the issue, can you help review and merge it? Thanks

MariaHCD

The code looks good to me. We've got a conflict, though.

# Conflicts: # src/libs/actions/Report.ts

narefyev91 · 2024-05-24T08:17:27Z

The code looks good to me. We've got a conflict, though.

Resolved!

MariaHCD

LGTM, we've got a merge freeze happening now, requesting this week's App deployer to review this.

chiragsalian · 2024-05-24T23:10:53Z

This PR introduces a lint warning on main so i had to revert it so that i could continue merging other PRs without ESLint failing. Further explained here.

Please recreate the PR and address the ESLint error when working on this. Can be tested locally using,

npx eslint src/pages/home/report/ReportActionsView.tsx

and confirm you don't see any errors or warnings.

OSBotify · 2024-05-27T14:26:11Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-29T09:18:52Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

narefyev91 added 2 commits May 20, 2024 18:59

Fix linked message visibility in offline mode

b325bb0

update condition

61a5653

narefyev91 marked this pull request as ready for review May 21, 2024 14:28

narefyev91 requested a review from a team as a code owner May 21, 2024 14:28

melvin-bot bot requested review from dukenv0307 and removed request for a team May 21, 2024 14:28

no need to fetch new actions in linked message and offline mode

f86f0e6

dukenv0307 reviewed May 23, 2024

View reviewed changes

src/pages/home/report/ReportActionsView.tsx Outdated Show resolved Hide resolved

update after c+ review

2d9caaf

dukenv0307 approved these changes May 24, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD May 24, 2024 03:45

MariaHCD reviewed May 24, 2024

View reviewed changes

Merge branch 'refs/heads/main' into fix-broken-view-of-linked-messages

6e35566

# Conflicts: # src/libs/actions/Report.ts

MariaHCD approved these changes May 24, 2024

View reviewed changes

chiragsalian merged commit 3905b5e into Expensify:main May 24, 2024
16 checks passed

chiragsalian mentioned this pull request May 24, 2024

Revert "Fix linked message visibility in offline mode" #42612

Merged

48 tasks

narefyev91 mentioned this pull request May 27, 2024

Fix linked message visibility in offline mode #42628

Merged

50 tasks

github-actions bot mentioned this pull request May 27, 2024

Deploy Checklist: New Expensify 2024-05-27 #42636

Closed

69 tasks

melvin-bot bot mentioned this pull request May 29, 2024

[PAID] [$250] IOU - User is stuck on the same page after navigating to IOU preview link twice offline #41063

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix linked message visibility in offline mode #42396

Fix linked message visibility in offline mode #42396

narefyev91 commented May 20, 2024 •

edited

Loading

melvin-bot bot commented May 21, 2024

dukenv0307 commented May 22, 2024 •

edited

Loading

narefyev91 commented May 22, 2024

dukenv0307 commented May 22, 2024 •

edited

Loading

dukenv0307 commented May 22, 2024

narefyev91 commented May 22, 2024

narefyev91 commented May 22, 2024

dukenv0307 commented May 23, 2024

narefyev91 commented May 23, 2024

melvin-bot bot commented May 24, 2024

dukenv0307 commented May 24, 2024

MariaHCD left a comment

narefyev91 commented May 24, 2024

MariaHCD left a comment •

edited

Loading

chiragsalian commented May 24, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

Fix linked message visibility in offline mode #42396

Fix linked message visibility in offline mode #42396

Conversation

narefyev91 commented May 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 21, 2024

dukenv0307 commented May 22, 2024 • edited Loading

narefyev91 commented May 22, 2024

dukenv0307 commented May 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented May 22, 2024

narefyev91 commented May 22, 2024

narefyev91 commented May 22, 2024

dukenv0307 commented May 23, 2024

narefyev91 commented May 23, 2024

melvin-bot bot commented May 24, 2024

dukenv0307 commented May 24, 2024

MariaHCD left a comment

Choose a reason for hiding this comment

narefyev91 commented May 24, 2024

MariaHCD left a comment • edited Loading

Choose a reason for hiding this comment

chiragsalian commented May 24, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

narefyev91 commented May 20, 2024 •

edited

Loading

dukenv0307 commented May 22, 2024 •

edited

Loading

dukenv0307 commented May 22, 2024 •

edited

Loading

MariaHCD left a comment •

edited

Loading