-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline auto suggestion #42630
Inline auto suggestion #42630
Conversation
…nline-auto-suggestion
…nline-auto-suggestion
@alitoshmatov, since you were a reviewer of the original PR, I guess it makes sense for you to take it again, wdyt? |
Sure, I can review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a design perspective this looks good. #not-an-engineer
…nline-auto-suggestion
Everything looks good in testing, but I haven't finished reviewing all the change since there are a lot of them. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chromesugestions-mweb.moviOS: Nativesugestions-ios.mp4iOS: mWeb Safarisugestions-safari.mp4MacOS: Chrome / Safarisugestions-web.movMacOS: Desktopsugestions-desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
@puneetlath, it looks like we're good to go 🚀 |
src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/index.native.tsx
Outdated
Show resolved
Hide resolved
Let's see if we can get this through without regressions and having to revert 🤞🏾 Merging! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.86-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.86-0 🚀
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.86-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀
|
Details
This PR updates the suggestion box to appear right next to the cursor, making it work like inline autosuggestion.
Patch
iOS-textinput-onscroll-event
should be removed once we update RN to 74.2Fixed Issues
$ #16078
PROPOSAL:
Tests
Testing Emoji Suggestions:
Testing Mention Suggestions:
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
2024-02-27.17.46.06.mp4
Android: mWeb Chrome
2024-02-27.17.46.14.mp4
iOS: Native
Simulator.Screen.Recording.-.14.Pro.-.2024-02-27.at.17.35.37.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.14.Pro.-.2024-02-27.at.17.36.05.mp4
MacOS: Chrome / Safari
Untitled.3.mov
MacOS: Desktop