-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix language for consistent use of "with Expensify" #42658
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@jasperhuangg not sure why it says Travis Failure, all checks seem to pass... |
@carlosmiceli hmm I don't see a travis failure on my end of things, merging is blocked because you don't have an approval on the PR though. |
That's great! Yeah, no rush on the PR approval, but wanted to check that Travis was working fine for you :) |
@carlosmiceli Can you include screenshots for Web? |
Sorry, I'm confused, didn't see that error in OldDot (is that what you mean?), only in App. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 1.4.77-11 🚀
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 1.4.77-11 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀
|
Changing "using Expensify" for "with Expensify" for consistency across the app according to the decision in the issue below. This is part of the full solution, this PR in Web-E covers the PHP fixes.
Details
This fixes "using Expensify" when the transaction fails for any reason and the text from App is used instead:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/392063
Tests
1- Submit an expense to another account or via a workspace.
2- Force an error for the upcoming payment with the other account (e.g.: disconnect from the DB)
3- Pay it with Expensify.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop