Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onyx to 2.0.48 (after revert) #42772

Merged
Merged
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
31e6e87
Revert "Merge pull request #42725 from Expensify/vit-revert42057"
chrispader May 29, 2024
760f8b6
update package-lock.json
chrispader May 29, 2024
6322c8f
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader May 30, 2024
317b5ab
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader May 31, 2024
2867f5e
update to Onyx 2.0.43
chrispader May 31, 2024
cb0711e
fix: report related null chnages
chrispader May 31, 2024
1fde464
migrate more tests
chrispader May 31, 2024
903b841
migrate more components
chrispader May 31, 2024
74e120c
migrate more components
chrispader May 31, 2024
e35b748
migrate more files
chrispader May 31, 2024
cfb7b2d
migrate more files
chrispader May 31, 2024
0778946
fix: migrate more files
chrispader May 31, 2024
8c5ff84
fix: tests
chrispader May 31, 2024
d0d896b
Merge branch 'main' into @chrispader/onyx-2-0-43-null-undefined-changes
chrispader May 31, 2024
2bd8bdf
update to onyx 2.0.44
chrispader May 31, 2024
f51e241
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader May 31, 2024
7072973
Merge branch '@chrispader/after-revert-bump-onyx-to-2-0-42' into @chr…
chrispader May 31, 2024
73df712
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 3, 2024
58819b4
Merge branch '@chrispader/after-revert-bump-onyx-to-2-0-42' into @chr…
chrispader Jun 3, 2024
1d4e462
fix: Onyx.connect callback types
chrispader Jun 4, 2024
7b71d22
fix: remaining TS errors
chrispader Jun 4, 2024
475efac
fix: more TS errors
chrispader Jun 4, 2024
8890183
fix: login not working
chrispader Jun 4, 2024
1a1a832
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 5, 2024
3bc14fe
Merge branch '@chrispader/after-revert-bump-onyx-to-2-0-42' into @chr…
chrispader Jun 5, 2024
cc278f4
fix: login
chrispader Jun 5, 2024
a00b9b0
set credentials to null by default
chrispader Jun 5, 2024
2d26f6d
fix: cannot login issue
chrispader Jun 5, 2024
1d8cf8d
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 5, 2024
3bfae91
Merge branch '@chrispader/after-revert-bump-onyx-to-2-0-42' into @chr…
chrispader Jun 5, 2024
923133c
fix: initial network load
chrispader Jun 5, 2024
224ed07
add OnyxInputOrEntry type
chrispader Jun 5, 2024
41824e5
add to index
chrispader Jun 5, 2024
8ba588f
fix: IOU
chrispader Jun 5, 2024
dd7e9dd
fix: remaining IOU issues
chrispader Jun 5, 2024
11c8e94
rename type
chrispader Jun 5, 2024
3105b2e
fix: minor issues
chrispader Jun 5, 2024
e8d60aa
fix: initial hasTriedFocusMode
chrispader Jun 5, 2024
72f1cdd
fix: PushNotification
chrispader Jun 5, 2024
0bde2bf
fix: PersonalDetailsUtils
chrispader Jun 5, 2024
38bf703
fix: User
chrispader Jun 5, 2024
f13c27e
fix: ReportScreen null values
chrispader Jun 5, 2024
a93bafd
fix: ReportActionCompose
chrispader Jun 5, 2024
ad4186a
fix: props
chrispader Jun 5, 2024
3d8e6f6
remove unnecessary null coallescing
chrispader Jun 5, 2024
e6bcbe6
fix: OptionsListUtils
chrispader Jun 5, 2024
57ae961
fix: RemoveEMptyActionDrafts
chrispader Jun 5, 2024
afce282
fix: null values
chrispader Jun 5, 2024
38f0931
fix: FlagCommentPage
chrispader Jun 5, 2024
a90bfa2
fix: lastReportAction
chrispader Jun 5, 2024
7a44c68
fix: BaseReportActionContextMenu
chrispader Jun 5, 2024
263dd3c
fix: MoneyRequestView
chrispader Jun 5, 2024
7afdf8f
ReportUtils
chrispader Jun 5, 2024
007402a
fix: remaining files
chrispader Jun 5, 2024
8ec33e8
fix: remaining TS errors
chrispader Jun 5, 2024
f2bb29c
rename SignInPage components (these were my edits originally)
chrispader Jun 6, 2024
5bedde5
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 6, 2024
0babd7d
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 6, 2024
eedb10b
Merge branch '@chrispader/after-revert-bump-onyx-to-2-0-42' into @chr…
chrispader Jun 6, 2024
5ad5b93
fix: imports
chrispader Jun 6, 2024
9957f98
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 7, 2024
d3d0e91
Merge branch '@chrispader/after-revert-bump-onyx-to-2-0-42' into @chr…
chrispader Jun 7, 2024
d931437
fix: Member.ts
chrispader Jun 7, 2024
2e70512
update to onyx 2.0.47
chrispader Jun 7, 2024
29ce13f
Merge pull request #20 from margelo/@chrispader/onyx-2-0-43-null-unde…
chrispader Jun 7, 2024
8c3a560
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 7, 2024
2eee633
fix: TS errors
chrispader Jun 7, 2024
ded0880
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 7, 2024
e5b53c6
fix: ESLint errors
chrispader Jun 7, 2024
bbb64c8
add JS doc comment
chrispader Jun 7, 2024
78e5d41
fix: compose box disappears
chrispader Jun 10, 2024
06948db
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 10, 2024
e4b18e2
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 11, 2024
5988121
fix: workspace avatar flashing with default avatar
chrispader Jun 11, 2024
bf99a86
fix: TS errors
chrispader Jun 11, 2024
8081d63
update onyx
chrispader Jun 11, 2024
da29f01
re-trigger TS pipeline
chrispader Jun 11, 2024
6cde1b7
add back empty line
chrispader Jun 11, 2024
4864934
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 12, 2024
a515cc0
fix: TS error
chrispader Jun 12, 2024
df5e65f
simplify parentReportAction prop drilling in ReportActionItem chain
chrispader Jun 12, 2024
14fe781
remove unused minor changes
chrispader Jun 12, 2024
b905341
skip performance tests
OlimpiaZurek Jun 12, 2024
3c4c177
Merge pull request #21 from callstack-internal/fix/43549/skip-problem…
chrispader Jun 12, 2024
77dc8d3
fix: transaction thread rendered
chrispader Jun 12, 2024
8bab925
fix: TS error
chrispader Jun 12, 2024
732e9b5
fix: prettier diff
chrispader Jun 12, 2024
dfb0b2c
Merge branch 'main' into @chrispader/after-revert-bump-onyx-to-2-0-42
chrispader Jun 12, 2024
bfcf8b3
fix: don't fallback to null
chrispader Jun 12, 2024
03f243d
fix: return authToken as is from NetworkStore
chrispader Jun 12, 2024
e115cdc
fix: remaining issues
chrispader Jun 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: don't fallback to null
  • Loading branch information
chrispader committed Jun 12, 2024
commit bfcf8b38b3e082f082cd65a28eaf76ff7c4cc636
4 changes: 2 additions & 2 deletions src/libs/Network/NetworkStore.ts
Original file line number Diff line number Diff line change
@@ -85,8 +85,8 @@ Onyx.connect({
},
});

function getCredentials(): Credentials | null {
return credentials ?? null;
function getCredentials(): Credentials | null | undefined {
return credentials;
}

function isOffline(): boolean {