Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Display blocking view and remove download button when user have no access to the report" #42877

Conversation

tylerkaraszewski
Copy link
Contributor

Reverts #42312

@tylerkaraszewski tylerkaraszewski requested a review from a team as a code owner May 30, 2024 22:13
@melvin-bot melvin-bot bot removed the request for review from a team May 30, 2024 22:13
Copy link

melvin-bot bot commented May 30, 2024

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from nkuoch May 30, 2024 22:13
@tylerkaraszewski
Copy link
Contributor Author

Straight revert because of failing test.

@tylerkaraszewski tylerkaraszewski requested a review from a team May 30, 2024 22:18
@melvin-bot melvin-bot bot removed the request for review from a team May 30, 2024 22:18
Copy link

melvin-bot bot commented May 30, 2024

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -1,4 +1,3 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this blank line why the linter was failing? Maybe just try npm run prettier from main as an alternative.

@francoisl francoisl deleted the revert-42312-handle-openning-attachments-without-access branch May 30, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants