[Wave Collect] [Xero] Remove text jitter for More Features modal #42919

mananjadhav · 2024-05-31T13:07:05Z

Details

For the More Features page, we had some content to show on modal when we clicked on the restricted switches. The first implementation used a common state {isOpen: boolean, itemType: 'organize' | 'integrate'} based on the section.

When we set isOpen: false, itemType: undefined on cancel of the modal, there was a small jitter with the modal. The modal was still being closed and unsetting itemType caused the description to disappear and popup to resize. The reason I set this undefined (or even have itemType) is because I was using the same modal and conditionally setting the prompt. With a basic if..else, when the modal was being closed the text used to change (the way it's being cleared).

This PR fixes it by having different the isOpen flags and modals for each section. This way the content is static for the modal, and modal closing doesn't hinder with the content.

Fixed Issues

$ #42903
$ #42644

PROPOSAL:

Tests

Open the app
Open any workspace with an existing accounting integration - say, Xero or QBO..
Click on More Features.
Go to Organize section and try clicking on any of the switches.
Verify that you see a modal with the following content & click on "Cancel"
Verify that the prompt text (description) doesn't disappear while the modal closes, and the dimension of the modal doesn't change.

Verify that no errors appear in the JS console

Offline tests

Same as Test Steps

QA Steps

Same as Test Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-connection-modal-content.mov

Android: mWeb Chrome

mweb-chrome-connection-modal-content.mov

iOS: Native

ios-connection-modal-content.mov

iOS: mWeb Safari

mweb-safari-connection-modal-content.mov

MacOS: Chrome / Safari

web-connection-modal-content.mov

MacOS: Desktop

desktop-connection-modal-content.mov

melvin-bot · 2024-05-31T13:07:11Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-05-31T13:18:09Z

Is there someone else who will review this or shall I go ahead?

mananjadhav · 2024-05-31T14:32:51Z

@c3024 This will be reviewed by @hungvu193 or @rushatgabhane. Thanks for checking.

I am still left with adding screencasts for all platforms. No electricity. Will update when it comes back.

rushatgabhane · 2024-05-31T16:03:46Z

@mananjadhav nothing urgent, could you please briefly explain the changes. Why and how it's fixed 😁

mananjadhav · 2024-05-31T16:27:46Z

@rushatgabhane I've updated the Details section and also uploaded all the screencasts.

mananjadhav · 2024-06-02T16:19:05Z

@rushatgabhane @hungvu193 Can one of you help with the review here?

hungvu193 · 2024-06-02T16:28:27Z

It's being late here. I can do a quick review in my morning if Rushat isn't available

mananjadhav · 2024-06-02T16:30:38Z

Tomorrow is fine, either one of you can do it. Thank you 🙏

hungvu193 · 2024-06-03T02:18:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-03.at.09.48.01.mov

Android: mWeb Chrome

iOS: Native

IOS.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

hungvu193

LGTM! 🚀

hungvu193 · 2024-06-04T02:35:08Z

@lakchote This will be ready for your final review

OSBotify · 2024-06-04T10:37:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:36:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 3 commits May 31, 2024 18:18

fix: simplify modal state

05b7954

fix: flag condition

a57e8c3

fix: prettier fix

32110d9

mananjadhav requested a review from a team as a code owner May 31, 2024 13:07

melvin-bot bot requested review from c3024 and removed request for a team May 31, 2024 13:07

hungvu193 approved these changes Jun 3, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote June 3, 2024 02:49

MariaHCD approved these changes Jun 4, 2024

View reviewed changes

MariaHCD merged commit ba5c201 into Expensify:main Jun 4, 2024
17 checks passed

MariaHCD mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-13] More feature Popup - Text under "not so fast" quickly disappears & slightly shrinks popup #42903

Closed

6 tasks

github-actions bot mentioned this pull request Jun 4, 2024

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

melvin-bot bot mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [Wave Collect] [Xero] Implement the More Features change #42644

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wave Collect] [Xero] Remove text jitter for More Features modal #42919

[Wave Collect] [Xero] Remove text jitter for More Features modal #42919

mananjadhav commented May 31, 2024 •

edited

Loading

melvin-bot bot commented May 31, 2024

c3024 commented May 31, 2024 •

edited

Loading

mananjadhav commented May 31, 2024

rushatgabhane commented May 31, 2024 •

edited

Loading

mananjadhav commented May 31, 2024

mananjadhav commented Jun 2, 2024

hungvu193 commented Jun 2, 2024

mananjadhav commented Jun 2, 2024

hungvu193 commented Jun 3, 2024 •

edited

Loading

hungvu193 left a comment

hungvu193 commented Jun 4, 2024

OSBotify commented Jun 4, 2024

OSBotify commented Jun 6, 2024

[Wave Collect] [Xero] Remove text jitter for More Features modal #42919

[Wave Collect] [Xero] Remove text jitter for More Features modal #42919

Conversation

mananjadhav commented May 31, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 31, 2024

c3024 commented May 31, 2024 • edited Loading

mananjadhav commented May 31, 2024

rushatgabhane commented May 31, 2024 • edited Loading

mananjadhav commented May 31, 2024

mananjadhav commented Jun 2, 2024

hungvu193 commented Jun 2, 2024

mananjadhav commented Jun 2, 2024

hungvu193 commented Jun 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

hungvu193 commented Jun 4, 2024

OSBotify commented Jun 4, 2024

OSBotify commented Jun 6, 2024

mananjadhav commented May 31, 2024 •

edited

Loading

c3024 commented May 31, 2024 •

edited

Loading

rushatgabhane commented May 31, 2024 •

edited

Loading

hungvu193 commented Jun 3, 2024 •

edited

Loading