Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken list components on staging #4300

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Fix broken list components on staging #4300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/components/OptionsList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ class OptionsList extends Component {
this.renderSectionHeader = this.renderSectionHeader.bind(this);
this.extractKey = this.extractKey.bind(this);
this.onScrollToIndexFailed = this.onScrollToIndexFailed.bind(this);
this.onViewableItemsChanged = this.onViewableItemsChanged.bind(this);
this.viewabilityConfig = {viewAreaCoveragePercentThreshold: 95};
this.didLayout = false;
}
Expand All @@ -137,6 +138,15 @@ class OptionsList extends Component {
return false;
}

onViewableItemsChanged() {
if (this.didLayout || !this.props.onLayout) {
return;
}

this.didLayout = true;
this.props.onLayout();
}

/**
* We must implement this method in order to use the ref.scrollToLocation() method.
* See: https://reactnative.dev/docs/sectionlist#scrolltolocation
Expand Down Expand Up @@ -238,14 +248,7 @@ class OptionsList extends Component {
maxToRenderPerBatch={5}
windowSize={5}
viewabilityConfig={this.viewabilityConfig}
onViewableItemsChanged={() => {
if (this.didLayout) {
return;
}

this.didLayout = true;
this.props.onLayout();
}}
onViewableItemsChanged={this.onViewableItemsChanged}
/>
</View>
);
Expand Down