Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add HybridApp deploy to platform deploy" #43078

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Revert "Add HybridApp deploy to platform deploy" #43078

merged 1 commit into from
Jun 4, 2024

Conversation

AndrewGable
Copy link
Contributor

Reverts #43046

@AndrewGable AndrewGable marked this pull request as ready for review June 4, 2024 22:27
@AndrewGable AndrewGable requested a review from a team as a code owner June 4, 2024 22:27
@melvin-bot melvin-bot bot requested review from bondydaa and removed request for a team June 4, 2024 22:27
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 4, 2024

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham
roryabraham approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, skipping checklists for straight revert

@roryabraham roryabraham merged commit 6869040 into main Jun 4, 2024
14 of 16 checks passed
@roryabraham roryabraham deleted the revert-43046-andrew-hybrid-deploy-2 branch June 4, 2024 22:29
@melvin-bot melvin-bot bot added the Emergency label Jun 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 4, 2024

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@roryabraham
Copy link
Contributor

see last comment

OSBotify pushed a commit that referenced this pull request Jun 4, 2024
@roryabraham @OSBotify
Merge pull request #43078 from Expensify/revert-43046-andrew-hybrid-d…
edfae63 
…eploy-2

Revert "Add HybridApp deploy to platform deploy"

(cherry picked from commit 6869040)
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jun 4, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2024

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@bondydaa bondydaa Awaiting requested review from bondydaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewGable @roryabraham @OSBotify