-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Commit Podfile.lock diff #43150
Conversation
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
throwing a quick HOLD on this to see if I can fix |
Fixed the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[No QA] Commit Podfile.lock diff (cherry picked from commit 5b56d76)
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.79-11 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀
|
Details
In #40872 we bumped reanimated JS without bumping the corresponding pod version. This PR just commits the diff that occurs on main if you run:
Fixed Issues
$ n/a
Tests
Run the iOS app, make sure it builds and operates as necessary. I actually had to include this diff for the build to work locally (had to do a pod install).
QA Steps
None.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
RPReplay_Final1717621410.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop