Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dismissing the error for corrupted PDF scan request does not delete the expense #43346

Merged
merged 8 commits into from
Jun 21, 2024
Merged

fix: Dismissing the error for corrupted PDF scan request does not delete the expense #43346

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d04a90
fix: Dismissing the error for corrupted PDF scan request does not del…
nkdengineer Jun 10, 2024
2f645fb
Merge branch 'main' into fix/42120
nkdengineer Jun 17, 2024
8a2df50
Update src/components/ReportActionItem/MoneyRequestView.tsx
nkdengineer Jun 21, 2024
2866a96
Update src/components/ReportActionItem/MoneyRequestView.tsx
nkdengineer Jun 21, 2024
76a247a
Merge branch 'main' into fix/42120
nkdengineer Jun 21, 2024
f4b30e9
fix: delete useCallBack in deleteTransaction
nkdengineer Jun 21, 2024
fdc25d6
Merge branch 'main' into fix/42120
nkdengineer Jun 21, 2024
3d724a6
fix typecheck
nkdengineer Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/components/ReportActionItem/MoneyRequestView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import * as CardUtils from '@libs/CardUtils';
import * as CurrencyUtils from '@libs/CurrencyUtils';
import type {MileageRate} from '@libs/DistanceRequestUtils';
import DistanceRequestUtils from '@libs/DistanceRequestUtils';
import * as ErrorUtils from '@libs/ErrorUtils';
import * as OptionsListUtils from '@libs/OptionsListUtils';
import * as PolicyUtils from '@libs/PolicyUtils';
import {isTaxTrackingEnabled} from '@libs/PolicyUtils';
Expand Down Expand Up @@ -282,6 +283,18 @@ function MoneyRequestView({
[transactionAmount, isSettled, isCancelled, isPolicyExpenseChat, isEmptyMerchant, transactionDate, hasErrors, hasViolations, translate, getViolationsForField],
);

const deleteTransaction = useCallback(() => {
if (!parentReportAction) {
return;
}
const iouTransactionID = parentReportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? parentReportAction.originalMessage?.IOUTransactionID ?? '-1' : '-1';
if (ReportActionsUtils.isTrackExpenseAction(parentReportAction)) {
IOU.deleteTrackExpense(parentReport?.reportID ?? '-1', iouTransactionID, parentReportAction, true);
return;
}
IOU.deleteMoneyRequest(iouTransactionID, parentReportAction, true);
}, [parentReport?.reportID, parentReportAction]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no point in using useCallback here since you are not passing down this function to another component and you are not using it in another function wrapped in useCallback.

Can you instead define this function outside of the component and receive as parameters parentReport and parentReportAction 🙏 ?

Then later you call it with deleteTransaction(parentReport, parentReportAction)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldo-expensify please check again


const distanceRequestFields = canUseP2PDistanceRequests ? (
<>
<OfflineWithFeedback pendingAction={getPendingFieldAction('waypoints')}>
Expand Down Expand Up @@ -391,6 +404,9 @@ function MoneyRequestView({
if (!transaction?.transactionID) {
return;
}
if (Object.values(transaction?.errors ?? {})?.find((error) => ErrorUtils.isReceiptError(error))) {
deleteTransaction();
}
Transaction.clearError(transaction.transactionID);
ReportActions.clearAllRelatedReportActionErrors(report.reportID, parentReportAction);
}}
Expand Down
Loading