-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workspace's default currency when submitting expense #43416
Conversation
Will add videos in sometime. |
@ShridharGoel Can you please add the testing steps and the screenshots? |
Will try to add them within 24 hours.
|
Added the videos except native Android (facing some build issue). |
@ShridharGoel Could you please add the testing steps section? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge main, there is a lint check failure.
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2024-06-24.at.15.51.16.mp4Android: mWeb ChromeCleanShot.2024-06-24.at.15.53.30.mp4iOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-24.at.16.09.13.mp4iOS: mWeb SafariCleanShot.2024-06-24.at.16.11.12.mp4MacOS: DesktopCleanShot.2024-06-24.at.15.33.00.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.2-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
Details
Use workspace's default currency when submitting expense.
Fixed Issues
$ #42597
PROPOSAL: #42597 (comment)
Test steps
QA steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-06-18.at.11.21.25.PM.mov
iOS: Native
Screen.Recording.2024-06-18.at.10.48.58.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-06-18.at.11.21.25.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-06-18.at.4.43.02.PM.mov
MacOS: Desktop
Screen.Recording.2024-06-18.at.4.48.25.PM.mov