chore: add onDismiss handler for TaxPicker #43521

dominictb · 2024-06-12T02:22:59Z

Details

Add onDismiss handler for TaxPicker

Fixed Issues

$ #42854
PROPOSAL: #42854 (comment)

Tests

Go to the app
Go to workspace settings
Go to Taxes (enable it if not enabled)
Click Settings
Click Workspace currency default
Click on the selected tax rate

App will not unselect the tax rate since Workspace currency default must have a tax rate. No error happens

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to the app
Go to workspace settings
Go to Taxes (enable it if not enabled)
Click Settings
Click Workspace currency default
Click on the selected tax rate

App will not unselect the tax rate since Workspace currency default must have a tax rate. No error happens

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

aweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

iosweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

Signed-off-by: dominictb <tb-dominic@outlook.com> Signed-off-by: dominictb <tb-dominic@outlook.com>

Signed-off-by: dominictb <tb-dominic@outlook.com>

melvin-bot · 2024-06-13T10:20:10Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-06-14T07:56:55Z

src/components/TaxPicker.tsx

@@ -54,9 +54,11 @@ type TaxPickerProps = TaxPickerOnyxProps & {

    /** The type of IOU */
    iouType?: ValueOf<typeof CONST.IOU.TYPE>;
+
+    onDismiss: () => void;


I think goBack or navigateBack name will be more correct and meaningful 😄

onDismiss is fine. It matches with onSubmit handler name

@dominictb Yeah, but in this case, we execute the goBack action not dismiss action. As I understand about our codebase, dismiss action only be triggered when we want to turn off the modal or keyboard.

I don't think it makes sense. Inside the TaxPicker, onDismiss is an generic event. It shouldn't be specific to any action like goBack or closeModal.

My concern about the dismiss word 😄. It doesn't match with the implementation of this function, this function executes goBack action

goBack is too specific. What if the TaxPicker is inside a modal and you want to dismiss it? I think, dismiss is a generic word referencing a generic action/event in this case, i.e Do nothing case.

DylanDylann · 2024-06-14T07:57:21Z

src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx

@@ -38,6 +38,10 @@ function WorkspaceTaxesSettingsForeignCurrency({
        Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
    };

+    const onDismiss = () => {


update to dismiss

DylanDylann · 2024-06-14T07:57:49Z

src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx

@@ -113,6 +113,10 @@ function IOURequestStepTaxRatePage({
        navigateBack();
    };

+    const dismiss = () => {


It matches with submit handler name

DylanDylann · 2024-06-14T08:00:09Z

This code should also be removed on this PR

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx

Lines 88 to 91 in 2144fc6

    
           if (newTaxCode === TransactionUtils.getTaxCode(currentTransaction)) { 
        
               navigateBack(); 
        
               return; 
        
           }

DylanDylann · 2024-06-14T08:06:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-14.at.15.15.08.mov

Android: mWeb Chrome

Screen.Recording.2024-06-14.at.15.13.16.mov

iOS: Native

Screen.Recording.2024-06-14.at.15.14.52.mov

iOS: mWeb Safari

Screen.Recording.2024-06-14.at.15.14.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-14.at.15.09.16.mov

MacOS: Desktop

Screen.Recording.2024-06-14.at.15.12.15.mov

DylanDylann · 2024-06-14T08:17:19Z

@dominictb There are some minor comments. Please address it. Everything else is fine

Signed-off-by: dominictb <tb-dominic@outlook.com>

blimpich

LGTM!

OSBotify · 2024-06-17T16:51:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-17T23:47:56Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T00:05:22Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T16:02:07Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-21T16:48:57Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dominictb added 3 commits June 12, 2024 09:17

chore: add onDismiss handler for TaxPicker

82c6dd3

Signed-off-by: dominictb <tb-dominic@outlook.com> Signed-off-by: dominictb <tb-dominic@outlook.com>

fix: add dismiss func in IOURequestStepTaxRate

443bc2b

Signed-off-by: dominictb <tb-dominic@outlook.com>

fix: prettier

5292617

Signed-off-by: dominictb <tb-dominic@outlook.com>

dominictb marked this pull request as ready for review June 13, 2024 10:20

dominictb requested a review from a team as a code owner June 13, 2024 10:20

melvin-bot bot removed the request for review from a team June 13, 2024 10:20

melvin-bot bot requested a review from DylanDylann June 13, 2024 10:20

cretadn22 mentioned this pull request Jun 14, 2024

[HOLD for payment 2024-07-10] [$250] [Track tax] Disabled tax rate can be selected #43613

Closed

6 tasks

DylanDylann reviewed Jun 14, 2024

View reviewed changes

dominictb added 2 commits June 14, 2024 16:15

Merge remote-tracking branch 'origin/main' into fix/42854-tax-picker

c62c3bc

fix: rename functions

7c9396e

Signed-off-by: dominictb <tb-dominic@outlook.com>

DylanDylann approved these changes Jun 14, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich June 14, 2024 09:58

blimpich approved these changes Jun 17, 2024

View reviewed changes

blimpich merged commit d7c2781 into Expensify:main Jun 17, 2024
23 checks passed

github-actions bot mentioned this pull request Jun 17, 2024

Deploy Checklist: New Expensify 2024-06-17 #43871

Closed

44 tasks

melvin-bot bot mentioned this pull request Jun 21, 2024

[HOLD for payment 2024-06-28] [$250] Taxes - Selected tax rate for Workspace currency default can be unselected which causes error #42854

Closed

6 tasks

dominictb deleted the fix/42854-tax-picker branch July 11, 2024 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add onDismiss handler for TaxPicker #43521

chore: add onDismiss handler for TaxPicker #43521

dominictb commented Jun 12, 2024 •

edited

Loading

melvin-bot bot commented Jun 13, 2024

DylanDylann Jun 14, 2024

dominictb Jun 14, 2024

DylanDylann Jun 14, 2024

dominictb Jun 14, 2024 •

edited

Loading

DylanDylann Jun 14, 2024

dominictb Jun 14, 2024 •

edited

Loading

DylanDylann Jun 14, 2024

dominictb Jun 14, 2024

DylanDylann Jun 14, 2024

dominictb Jun 14, 2024

DylanDylann commented Jun 14, 2024

DylanDylann commented Jun 14, 2024 •

edited

Loading

DylanDylann commented Jun 14, 2024

blimpich left a comment

OSBotify commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 21, 2024

chore: add onDismiss handler for TaxPicker #43521

chore: add onDismiss handler for TaxPicker #43521

Conversation

dominictb commented Jun 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominictb Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominictb Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented Jun 14, 2024

DylanDylann commented Jun 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Jun 14, 2024

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 21, 2024

dominictb commented Jun 12, 2024 •

edited

Loading

dominictb Jun 14, 2024 •

edited

Loading

dominictb Jun 14, 2024 •

edited

Loading

DylanDylann commented Jun 14, 2024 •

edited

Loading