Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User is able to upload a file larger than 50mb #4358

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix User is able to upload a file larger than 50mb #4358

merged 1 commit into from
Aug 2, 2021

Conversation

rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Aug 1, 2021

Details

Fixing regression caused by this PR.

Fixed Issues

$ #4356

Tests / QA

  1. Login to New Expensify.
  2. Navigate to a conversation.
  3. Click on add attachment.
  4. Select a file larger than 50mb.
  5. Verify that there is a message saying that the file must be under 50mb.

Tested On

  • iOS
  • Android

Web, mobile web, desktop aren't applicable.

Screenshots

iOS

Screen.Recording.2021-08-02.at.12.15.15.AM.mov

Android

@rushatgabhane rushatgabhane requested a review from a team as a code owner August 1, 2021 20:21
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team August 1, 2021 20:22
@iwiznia
Copy link
Contributor

iwiznia commented Aug 2, 2021

We need to CP this because it was introduced by a PR in staging

@iwiznia
Copy link
Contributor

iwiznia commented Aug 2, 2021

The CP check failed, but it seems because it's broken. More context (private link) here

@iwiznia iwiznia merged commit cc82f83 into Expensify:main Aug 2, 2021
@timszot
Copy link
Contributor

timszot commented Aug 2, 2021

@iwiznia did you test this at all? I was in the middle of testing....

github-actions bot pushed a commit that referenced this pull request Aug 2, 2021
Fix User is able to upload a file larger than 50mb

(cherry picked from commit cc82f83)
@iwiznia
Copy link
Contributor

iwiznia commented Aug 2, 2021

No, I did not, but @rushatgabhane did

@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2021

🚀 Cherry-picked to staging in version: 1.0.82-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@rushatgabhane
Copy link
Member Author

No, I did not, but @rushatgabhane did

Yes. Can assure the issue is resolved.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants