Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Sending -1 instead of 0 in case we don't have the localUpdateID #43654

Merged
merged 4 commits into from
Jun 13, 2024
Merged

[No QA] Sending -1 instead of 0 in case we don't have the localUpdateID #43654

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c55939
sending -1 instead of 0 in case we don't have the localUpdateID
danieldoglas Jun 13, 2024
544b8f6
prettier
danieldoglas Jun 13, 2024
792e5fd
breaking ternary into if
danieldoglas Jun 13, 2024
406d10e
simplifying if
danieldoglas Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/libs/API/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,16 @@ type OnyxData = {

// For all write requests, we'll send the lastUpdateID that is applied to this client. This will
// allow us to calculate previousUpdateID faster.
let lastUpdateIDAppliedToClient = 0;
let lastUpdateIDAppliedToClient = -1;
Onyx.connect({
key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT,
callback: (value) => (lastUpdateIDAppliedToClient = value ?? 0),
callback: (value) => {
if (value) {
lastUpdateIDAppliedToClient = value;
} else {
lastUpdateIDAppliedToClient = -1;
}
},
});

/**
Expand Down
Loading