Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workspace empty state #43669

Merged
merged 4 commits into from
Jun 20, 2024
Merged

fix workspace empty state #43669

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1771b7c
fix workspace empty state
Nodebrute Jun 13, 2024
16f9212
add icon in header
Nodebrute Jun 13, 2024
15098dd
Merge branch 'Expensify:main' into workspace
Nodebrute Jun 19, 2024
8ba48de
undo changes
Nodebrute Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2315,7 +2315,7 @@ export default {
importedFromAccountingSoftware: 'The taxes below are imported from your',
},
emptyWorkspace: {
title: 'Create a workspace',
title: 'Create a new workspace',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we can just keep the existing copy that we had before, sorry for the misleading mockup! Let's undo this change.

subtitle: 'Workspaces are where you’ll chat with your team, reimburse expenses, issue cards, send invoices, pay bills, and more - all in one place.',
createAWorkspaceCTA: 'Get Started',
features: {
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2354,7 +2354,7 @@ export default {
importedFromAccountingSoftware: 'Impuestos importadas desde',
},
emptyWorkspace: {
title: 'Crea un espacio de trabajo',
title: 'Crea un nuevo espacio de trabajo',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this translation verified?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment - I think we can just keep the existing copy that we had before, sorry for the misleading mockup! Let's undo this change.

subtitle: 'En los espacios de trabajo podrás chatear con tu equipo, reembolsar gastos, emitir tarjetas, enviar y pagar facturas, y mucho más - todo en un mismo lugar.',
createAWorkspaceCTA: 'Comenzar',
features: {
Expand Down
3 changes: 3 additions & 0 deletions src/pages/workspace/WorkspacesListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ function WorkspacesListPage({policies, reimbursementAccount, reports, session}:
title={translate('common.workspaces')}
shouldShowBackButton={isSmallScreenWidth}
onBackButtonPress={() => Navigation.goBack()}
icon={Illustrations.BigRocket}
>
<Button
accessibilityLabel={translate('workspace.new.newWorkspace')}
Expand All @@ -390,6 +391,7 @@ function WorkspacesListPage({policies, reimbursementAccount, reports, session}:
illustration={LottieAnimations.WorkspacePlanet}
// We use this style to vertically center the illustration, as the original illustration is not centered
illustrationStyle={styles.emptyWorkspaceIllustrationStyle}
titleStyles={styles.textHeadlineH1}
/>
</View>
</ScrollView>
Expand All @@ -408,6 +410,7 @@ function WorkspacesListPage({policies, reimbursementAccount, reports, session}:
title={translate('common.workspaces')}
shouldShowBackButton={isSmallScreenWidth}
onBackButtonPress={() => Navigation.goBack()}
icon={Illustrations.BigRocket}
>
<Button
accessibilityLabel={translate('workspace.new.newWorkspace')}
Expand Down
Loading