Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Disable initial focus in modals #43743

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[CP Staging] Disable initial focus in modals #43743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FocusTrap/FocusTrapForModal/index.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function FocusTrapForModal({children, active}: FocusTrapForModalProps) {
focusTrapOptions={{
trapStack: sharedTrapStack,
allowOutsideClick: true,
fallbackFocus: document.body,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to documentation if initialFocus is set to false fallbackFocus option is not used:

Setting this option to false (or a function that returns false) will prevent the fallbackFocus option from being used.

initialFocus: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we did not have a configurable initialFocus, we ran into initial focus issues for AttachmentModal in #43726

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we removed initial focus and fallbackFocus on document body, it introduced this bug on mSafari: #50661

More details in here: #50661 (comment)

}}
>
{children}
Expand Down
Loading