-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Display warning prompt when removing an approver from a control policy #44008
Conversation
… policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks how I'd expect it to from a design perspective 👍
@nkdengineer Please rephrase this to use the correct term displayed in OD (Approves To) to avoid confusion. Thanks. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari44008-web.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@nkdengineer Please remember to fix the text in the test preconditions.
@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Updated. |
Swapping @youssef-lr in to finish this review off. |
@Beamanator I updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me! Thanks for the quick changes!
@youssef-lr feel free to test if you'd like! I'll leave for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This PR is failing because of issue #44631 Bug6527483_1719585222590.2024-06-28_17-35-23.mp4Bug6527483_1719585222605.2024-06-28_17-22-15.mp4 |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
const confirmModalPrompt = useMemo(() => { | ||
const isApprover = Member.isApprover(policy, accountID); | ||
if (!isApprover) { | ||
translate('workspace.people.removeMemberPrompt', {memberName: displayName}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have returned the text here if the user was not a approver. We first set a message but later returned the approver message, this is kind of funny overlook but happens with the best of us.
This caused #45510
Details
Display warning prompt when removing an approver from a control policy
Fixed Issues
$ #43885
PROPOSAL: #43885 (comment)
Tests
Precondition:
[Selected member] is an approver in this workspace. When you unshare this workspace with them, we’ll replace them in the approval workflow with the workspace owner, [Workspace Owner].
Remove from workspace
buttonOffline tests
Same as above
QA Steps
Precondition:
[Selected member] is an approver in this workspace. When you unshare this workspace with them, we’ll replace them in the approval workflow with the workspace owner, [Workspace Owner].
Remove from workspace
buttonPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-06-19.at.22.12.28.mov
Android: mWeb Chrome
Screen.Recording.2024-06-19.at.22.09.21.mov
iOS: Native
Screen.Recording.2024-06-19.at.22.25.49.mov
iOS: mWeb Safari
Screen.Recording.2024-06-19.at.22.11.58.mov
MacOS: Chrome / Safari
Screen.Recording.2024-06-19.at.22.06.23.mov
MacOS: Desktop
Screen.Recording.2024-06-19.at.22.16.15.mov