-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Partial approved reports don’t have GBR in the LHN #44067
Conversation
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dominictb , can you check again the videos for ios Native and android Native, i feel you have uploaded the same videos on both options 😅 |
@allgandalf sorry, give me a moment. I'll update the video evidence again and let you know! |
@allgandalf updated |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-06-25.at.3.56.32.PM.movAndroid: mWeb ChromeScreen.Recording.2024-06-25.at.4.07.45.PM.moviOS: NativeScreen.Recording.2024-06-25.at.4.19.05.PM.moviOS: mWeb SafariScreen.Recording.2024-06-25.at.4.10.20.PM.movMacOS: Chrome / SafariScreen.Recording.2024-06-25.at.3.37.28.PM.movMacOS: DesktopScreen.Recording.2024-06-25.at.3.45.01.PM.mov |
@dominictb , can you quickly pull and merge main please, there have been latest changes on the |
@allgandalf update with latest main! |
NAB but can you rewrite the QA step to I will approve this PR in the meantime as this is technically complete and the bugs expected is matched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the issue of the wrong amount shown in the LHN
is something which needs to be addressed in other issue as dicussed before
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.2-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
Details
Fixed Issues
$ #43014
PROPOSAL: #43014 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
native.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov