-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix report doesn't scroll down to bottom when receiving new message #44132
Conversation
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
Hi @s77rt, could you add the screenshot/videos for the native and mWeb platforms? |
@marcochavezf Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.2-0 🚀
|
This PR is failing because of issue #43600 The issue is reproducible in: Web and Desktop 1719409808422.44132_Web_.mp41719386979930.2024-06-26_12-27-31.mp4 |
I am sorry @kbecciv, I cannot reproduce it in staging, Also, please don't send expense requests or other IOU requests beforehand because there is a bug related to cc: @s77rt Are you able to reproduce it? |
This is working as expected for me. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
Details
Fixed Issues
$ #43600
PROPOSAL: #43600 (comment)
Tests
Precondition: Please don't send expense requests or other IOU requests beforehand because there is a bug related to
hasNewestReportAction
that the auto-scroll depends on.Offline tests
QA Steps
Precondition: Please don't send expense requests or other IOU requests beforehand because there is a bug related to
hasNewestReportAction
that the auto-scroll depends on.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-native-d.mp4
Android: mWeb Chrome
android-mweb_d.mp4
iOS: Native
ios-native_d.mp4
iOS: mWeb Safari
ios-msfari_d.mp4
MacOS: Chrome / Safari
macos-web-d.mp4
MacOS: Desktop
macos-desktop_d.mp4