fix: delete money request if failed to create chat #44142

dominictb · 2024-06-21T10:55:52Z

Details

Fixed Issues

Tests

Log into NewDot
Create a workspace if needed
Go offline in the Network tab of dev tools, or using the force offline switch
Create a money request (distance type) on that workspace
Log into the same account, but in another device
Go to your group workspaces (in the other device)
Delete the workspace (in the other device)
Go back to NewDot in the first device
Verify the request fails to create
Click on the request
Verify there is an error message that says "Unexpected error submitting this expense. Please try again later...."
Click the X to dismiss the error

Expected result

The failed request should disappear completely after the error is dismissed. The transaction report should be deleted and the request should be removed from the workspace chat. Everything needs to be cleaned up. The user can get navigated back the the archived workspace chat

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log into NewDot
Create a workspace if needed
Go offline in the Network tab of dev tools, or using the force offline switch
Create a money request (distance type) on that workspace
Log into the same account, but in another device
Go to your group workspaces (in the other device)
Delete the workspace (in the other device)
Go back to NewDot in the first device
Verify the request fails to create
Click on the request
Verify there is an error message that says "Unexpected error submitting this expense. Please try again later...."
Click the X to dismiss the error

Expected result

The failed request should disappear completely after the error is dismissed. The transaction report should be deleted and the request should be removed from the workspace chat. Everything needs to be cleaned up. The user can get navigated back the the archived workspace chat

Expected result

The failed request should disappear completely after the error is dismissed. The transaction report should be deleted and the request should be removed from the workspace chat. Everything needs to be cleaned up. The user can get navigated back the the archived workspace chat

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

compressed_android.webm.mp4

Android: mWeb Chrome

compressed_aweb.webm.mp4

iOS: Native

compressed_ios.mp4.mp4

iOS: mWeb Safari

compressed_iosweb.mp4.mp4

MacOS: Chrome / Safari

compressed_web.mov.mp4

MacOS: Desktop

compressed_web.mov.mp4

Signed-off-by: dominictb <tb-dominic@outlook.com>

…req-error

melvin-bot · 2024-06-24T09:37:14Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: dominictb <tb-dominic@outlook.com>

sobitneupane · 2024-06-26T07:53:34Z

src/languages/es.ts

@@ -750,6 +750,7 @@ export default {
            atLeastTwoDifferentWaypoints: 'Por favor, introduce al menos dos direcciones diferentes.',
            splitExpenseMultipleParticipantsErrorMessage: 'Solo puedes dividir un gasto entre un único espacio de trabajo o con usuarios individuales. Por favor, actualiza tu selección.',
            invalidMerchant: 'Por favor, introduce un comerciante correcto.',
+            workspaceNotAccessible: 'El espacio de trabajo ya no está accesible. Por favor, intente de nuevo en un espacio de trabajo diferente.',


@dominictb We need to verify the Spanish translation of the error message.

sent a message on Slack

src/languages/en.ts

src/libs/Localize/index.ts

…req-error Signed-off-by: dominictb <tb-dominic@outlook.com>

Signed-off-by: dominictb <tb-dominic@outlook.com>

dominictb · 2024-06-26T14:44:26Z

translation slack thread: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1719403411690469

sobitneupane

@dominictb Can you please retest to see if you are getting the expected output because I am not getting the expected output following the reproduction steps in the PR description.

src/libs/Localize/index.ts

src/libs/actions/IOU.ts

dominictb · 2024-06-28T02:25:09Z

#44142 (review)

@sobitneupane I have updated the test step (in order to reproduce the exact error message, you have to create distance request). However, the behavior alone can be reproduced with any types of money request, just that the error messages returned by the BE is different.

sobitneupane · 2024-07-03T08:42:48Z

@dominictb Can you please test the case where there is already an existing request in the workspace. When we close the error message, we can still see the transaction with error in the transaction thread.

dominictb · 2024-07-03T10:25:41Z

@sobitneupane I'll get back to you about this shortly.

…req-error

when deleting report action of IOU report in cleanUpMoneyRequest function Signed-off-by: dominictb <tb-dominic@outlook.com>

dominictb · 2024-07-04T04:51:01Z

@sobitneupane fixed. Onyx filter out all undefined in merge data for updatedReportActions. Change it to null works as it will clean up the errors

Signed-off-by: dominictb <tb-dominic@outlook.com>

…req-error Signed-off-by: dominictb <tb-dominic@outlook.com>

dominictb · 2024-07-09T17:45:18Z

Still waiting for review.

sobitneupane · 2024-07-10T07:35:46Z

Sorry for the delay @dominictb

Some checks are still failing. Can you please handle that.

Signed-off-by: dominictb <tb-dominic@outlook.com>

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-11.at.14.19.08.mov

iOS: Native

Screen.Recording.2024-07-11.at.14.01.03.mov

iOS: mWeb Safari

Screen.Recording.2024-07-11.at.14.29.10.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-11.at.13.27.48.mov

Screen.Recording.2024-07-11.at.13.35.05.mov

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

neil-marcellini

Great work on this! It's a tough one. I left a lot of small recommendations, and there's something I want to check on before we send this out. I'll post a link to that conversation soon.

src/components/ReportActionItem/MoneyRequestView.tsx

src/libs/actions/IOU.ts

neil-marcellini · 2024-07-11T21:51:52Z

src/languages/msgTranslationKeySwapMapping.ts

Can we put these in CONST.ts instead, and use constants for the keys and values? I think we wouldn't have to eslint disable then and it would fit with our existing code patterns a little better.

Sure, but I'll wait for the team to decide on the swapForTranslation pattern before fixing this

src/libs/Localize/index.ts

neil-marcellini · 2024-07-11T21:59:15Z

src/components/ReportActionItem/MoneyRequestView.tsx

+        return Object.fromEntries(
+            Object.entries(combinedErrors).map(([key, value]) =>
+                // swap for translation for each error message
+                [key, swapForTranslation(value as string)],
+            ),
+        );


This is kind of a new pattern, so I want to check with the team first to see if everyone is cool with it, as recommended by our checklist.

I don't really like that we're doing the swapping within the component. Ideally the swapping would be done when saving an Onyx update from the network or pusher. Let's pause this work until we hear what the team thinks. Sorry for the delay, but if we build this right it will be useful in the future instead of a headache.

The approval conversation is here

Sorry, do you mean we should pause this PR or I should revert all the swapForTranslation change in this PR (in case the team is indecisive for a long time)?

Ideally the swapping would be done when saving an Onyx update from the network or pusher

It's not easy to do that since usually the error message returned from the BE is in the BE onyxData, which we don't have much control.

@dominictb yeah, please revert the swapForTranslation changes. I think we'll just deal with the slightly strange non-translated error message.

@neil-marcellini reverted

Signed-off-by: dominictb <tb-dominic@outlook.com>

…req-error

Signed-off-by: dominictb <tb-dominic@outlook.com>

neil-marcellini

Looks good, thank you! You'll need to fix conflicts before we can merge and lets have @sobitneupane run through the tests once more to make sure it's still working well.

…req-error

src/languages/en.ts

src/languages/es.ts

sobitneupane · 2024-07-17T08:55:03Z

Changes look good and test well.

Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np>

dominictb · 2024-07-17T11:48:14Z

done!

neil-marcellini

Thanks for catching the translations that we forgot to remove. Good to go!

OSBotify · 2024-07-17T19:40:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-18T14:12:24Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.9-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T11:55:05Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-19T19:36:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-23T08:02:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

getusha · 2024-10-28T07:36:56Z

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -410,6 +410,14 @@ function MoneyRequestView({
                            if (!transaction?.transactionID) {
                                return;
                            }
+
+                            const isCreateChatErrored = !!report?.errorFields?.createChat;


This caused a regression here, more details: #46662 (comment)

dominictb added 4 commits June 21, 2024 17:44

fix: delete money request if failed to create chat

dcc9ac9

Signed-off-by: dominictb <tb-dominic@outlook.com>

fix: add function to swap err message for local translation

ed0b37e

Signed-off-by: dominictb <tb-dominic@outlook.com>

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

caae66e

…req-error

fix: lint and prettier

7936055

dominictb marked this pull request as ready for review June 24, 2024 09:37

dominictb requested a review from a team as a code owner June 24, 2024 09:37

melvin-bot bot requested review from sobitneupane and removed request for a team June 24, 2024 09:37

dominictb added 3 commits June 24, 2024 16:37

fix: check optimistic report before cleaning up money request

68c4ca7

Signed-off-by: dominictb <tb-dominic@outlook.com>

chore: add translation

083c790

Signed-off-by: dominictb <tb-dominic@outlook.com>

fix: lint

5951c38

Signed-off-by: dominictb <tb-dominic@outlook.com>

sobitneupane reviewed Jun 26, 2024

View reviewed changes

src/libs/Localize/index.ts Outdated Show resolved Hide resolved

dominictb added 2 commits June 26, 2024 18:36

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

7a9c89b

…req-error Signed-off-by: dominictb <tb-dominic@outlook.com>

fix: improve translation key swapping logic

b383383

Signed-off-by: dominictb <tb-dominic@outlook.com>

sobitneupane reviewed Jun 27, 2024

View reviewed changes

src/libs/Localize/index.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

fix: comment

65bd81d

dominictb added 2 commits July 4, 2024 10:55

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

9b67b44

…req-error

fix: set errors and IOUTransactionID to null

041bed4

when deleting report action of IOU report in cleanUpMoneyRequest function Signed-off-by: dominictb <tb-dominic@outlook.com>

dominictb added 2 commits July 4, 2024 15:08

fix: typescript issue

41768f4

Signed-off-by: dominictb <tb-dominic@outlook.com>

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

bd32dd9

…req-error Signed-off-by: dominictb <tb-dominic@outlook.com>

fix: resolve typescript issues

0590632

Signed-off-by: dominictb <tb-dominic@outlook.com>

sobitneupane reviewed Jul 11, 2024

View reviewed changes

sobitneupane approved these changes Jul 11, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini July 11, 2024 08:55

neil-marcellini requested changes Jul 11, 2024

View reviewed changes

dominictb added 4 commits July 12, 2024 16:36

fix: update comments and clean up implementation

3730797

Signed-off-by: dominictb <tb-dominic@outlook.com>

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

83c0c3f

…req-error

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

51b8106

…req-error

fix: revert "swapForTranslation" change

4b79f38

Signed-off-by: dominictb <tb-dominic@outlook.com>

dominictb requested a review from neil-marcellini July 16, 2024 14:05

neil-marcellini previously approved these changes Jul 16, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/42950-clean-dist-…

313b1ca

…req-error

dominictb dismissed neil-marcellini’s stale review via 313b1ca July 17, 2024 06:17

sobitneupane reviewed Jul 17, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

src/languages/es.ts Outdated Show resolved Hide resolved

dominictb and others added 2 commits July 17, 2024 18:47

Remove en translation messsage

6ea8fc6

Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np>

Remove es translation message

d71f595

Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np>

sobitneupane approved these changes Jul 17, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini July 17, 2024 14:19

neil-marcellini approved these changes Jul 17, 2024

View reviewed changes

neil-marcellini merged commit 0c8e2cc into Expensify:main Jul 17, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 18, 2024

Deploy Checklist: New Expensify 2024-07-18 #45680

Closed

61 tasks

melvin-bot bot mentioned this pull request Jul 19, 2024

[HOLD for payment 2024-07-26] [$250] BUG: Failed distance request isn't cleaned up properly #42950

Closed

6 tasks

bernhardoj mentioned this pull request Aug 1, 2024

[HOLD for payment 2024-10-14] [$250] Expense - Main chat with RBR is not removed after dismissing error from expense report #46662

Closed

6 tasks

getusha reviewed Oct 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: delete money request if failed to create chat #44142

fix: delete money request if failed to create chat #44142

dominictb commented Jun 21, 2024 •

edited

Loading

melvin-bot bot commented Jun 24, 2024

sobitneupane Jun 26, 2024 •

edited

Loading

dominictb Jun 26, 2024

dominictb commented Jun 26, 2024

sobitneupane left a comment

dominictb commented Jun 28, 2024

sobitneupane commented Jul 3, 2024

dominictb commented Jul 3, 2024

dominictb commented Jul 4, 2024

dominictb commented Jul 9, 2024

sobitneupane commented Jul 10, 2024 •

edited

Loading

sobitneupane left a comment

sobitneupane left a comment

neil-marcellini left a comment

neil-marcellini Jul 11, 2024

dominictb Jul 12, 2024

neil-marcellini Jul 11, 2024

neil-marcellini Jul 11, 2024

dominictb Jul 12, 2024

dominictb Jul 12, 2024

neil-marcellini Jul 15, 2024

dominictb Jul 16, 2024

dominictb Jul 16, 2024

neil-marcellini left a comment

sobitneupane commented Jul 17, 2024

dominictb commented Jul 17, 2024

neil-marcellini left a comment

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 23, 2024

getusha Oct 28, 2024

fix: delete money request if failed to create chat #44142

fix: delete money request if failed to create chat #44142

Conversation

dominictb commented Jun 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 24, 2024

sobitneupane Jun 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominictb commented Jun 26, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

dominictb commented Jun 28, 2024

sobitneupane commented Jul 3, 2024

dominictb commented Jul 3, 2024

dominictb commented Jul 4, 2024

dominictb commented Jul 9, 2024

sobitneupane commented Jul 10, 2024 • edited Loading

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

neil-marcellini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

sobitneupane commented Jul 17, 2024

dominictb commented Jul 17, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 23, 2024

Choose a reason for hiding this comment

dominictb commented Jun 21, 2024 •

edited

Loading

sobitneupane Jun 26, 2024 •

edited

Loading

sobitneupane commented Jul 10, 2024 •

edited

Loading