[#Wave-Control: Add NetSuite]: Added NetSuite connect button and fixed copies
#44218
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import React from 'react'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import type {ConnectionName} from '@src/types/onyx/Policy'; | ||
| import ConfirmModal from './ConfirmModal'; | ||
|
|
||
| type AccountingConnectionConfirmationModalProps = { | ||
| integrationToConnect: ConnectionName; | ||
| onConfirm: () => void; | ||
| onCancel: () => void; | ||
| }; | ||
|
|
||
| function AccountingConnectionConfirmationModal({integrationToConnect, onCancel, onConfirm}: AccountingConnectionConfirmationModalProps) { | ||
| const {translate} = useLocalize(); | ||
|
|
||
| return ( | ||
| <ConfirmModal | ||
| title={translate('workspace.accounting.connectTitle', integrationToConnect)} | ||
| isVisible | ||
| onConfirm={onConfirm} | ||
| onCancel={onCancel} | ||
| prompt={translate('workspace.accounting.connectPrompt', integrationToConnect)} | ||
| confirmText={translate('workspace.accounting.setup')} | ||
| cancelText={translate('common.cancel')} | ||
| success | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| AccountingConnectionConfirmationModal.displayName = 'AccountingConnectionConfirmationModal'; | ||
| export default AccountingConnectionConfirmationModal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import React, {useState} from 'react'; | ||
| import AccountingConnectionConfirmationModal from '@components/AccountingConnectionConfirmationModal'; | ||
| import Button from '@components/Button'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useNetwork from '@hooks/useNetwork'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import {removePolicyConnection} from '@libs/actions/connections'; | ||
| import Navigation from '@libs/Navigation/Navigation'; | ||
| import CONST from '@src/CONST'; | ||
| import ROUTES from '@src/ROUTES'; | ||
| import type {ConnectToNetSuiteButtonProps} from './types'; | ||
|
|
||
| function ConnectToNetSuiteButton({policyID, shouldDisconnectIntegrationBeforeConnecting, integrationToDisconnect}: ConnectToNetSuiteButtonProps) { | ||
| const styles = useThemeStyles(); | ||
| const {translate} = useLocalize(); | ||
| const {isOffline} = useNetwork(); | ||
|
|
||
| const [isDisconnectModalOpen, setIsDisconnectModalOpen] = useState(false); | ||
|
|
||
| return ( | ||
| <> | ||
| <Button | ||
| onPress={() => { | ||
| if (shouldDisconnectIntegrationBeforeConnecting && integrationToDisconnect) { | ||
| setIsDisconnectModalOpen(true); | ||
| return; | ||
| } | ||
|
|
||
| // TODO: Will be updated to new token input page | ||
| Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR.getRoute(policyID)); | ||
| }} | ||
| text={translate('workspace.accounting.setup')} | ||
| style={styles.justifyContentCenter} | ||
| small | ||
| isDisabled={isOffline} | ||
| /> | ||
| {shouldDisconnectIntegrationBeforeConnecting && isDisconnectModalOpen && integrationToDisconnect && ( | ||
| <AccountingConnectionConfirmationModal | ||
| onConfirm={() => { | ||
| removePolicyConnection(policyID, integrationToDisconnect); | ||
|
|
||
| // TODO: Will be updated to new token input page | ||
| Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR.getRoute(policyID)); | ||
mananjadhav marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| setIsDisconnectModalOpen(false); | ||
| }} | ||
| integrationToConnect={CONST.POLICY.CONNECTIONS.NAME.NETSUITE} | ||
| onCancel={() => setIsDisconnectModalOpen(false)} | ||
| /> | ||
| )} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default ConnectToNetSuiteButton; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import type {PolicyConnectionName} from '@src/types/onyx/Policy'; | ||
|
|
||
| type ConnectToNetSuiteButtonProps = { | ||
| policyID: string; | ||
| shouldDisconnectIntegrationBeforeConnecting?: boolean; | ||
| integrationToDisconnect?: PolicyConnectionName; | ||
| }; | ||
|
|
||
| // eslint-disable-next-line import/prefer-default-export | ||
| export type {ConnectToNetSuiteButtonProps}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -2435,22 +2435,23 @@ export default { | |||||||
| syncNow: 'Sync now', | ||||||||
| disconnect: 'Disconnect', | ||||||||
| disconnectTitle: (integration?: ConnectionName): string => { | ||||||||
| const integrationName = integration && CONST.POLICY.CONNECTIONS.NAME_MAP[integration] ? CONST.POLICY.CONNECTIONS.NAME_MAP[integration] : 'integration'; | ||||||||
| return `Disconnect ${integrationName}`; | ||||||||
|
There was a problem hiding this comment. Can this be simplified down to:
Suggested change
There was a problem hiding this comment. Get a TS error. Hence I had to use this way. 
There was a problem hiding this comment. Can we just be strict with the types for the function? disconnectPrompt: (currentIntegration: ConnectionName): string => `Are you sure you want to disconnect ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[currentIntegration] ?? 'integration'}?`},There was a problem hiding this comment. Good point, let me check if it has any other usage. I can update. Give me a few mins. There was a problem hiding this comment. I was able to update it for
|
||||||||
| }, | ||||||||
| connectTitle: (integrationToConnect?: ConnectionName): string => { | ||||||||
| const integrationName = | ||||||||
| integrationToConnect && CONST.POLICY.CONNECTIONS.NAME_MAP[integrationToConnect] ? CONST.POLICY.CONNECTIONS.NAME_MAP[integrationToConnect] : 'accounting integration'; | ||||||||
| return `Connect ${integrationName}`; | ||||||||
| }, | ||||||||
|
There was a problem hiding this comment. Responded. #44218 (comment) |
||||||||
|
|
||||||||
| syncError: (integration?: ConnectionName): string => { | ||||||||
| switch (integration) { | ||||||||
| case CONST.POLICY.CONNECTIONS.NAME.QBO: | ||||||||
| return "Can't connect to QuickBooks Online."; | ||||||||
| case CONST.POLICY.CONNECTIONS.NAME.XERO: | ||||||||
| return "Can't connect to Xero."; | ||||||||
| case CONST.POLICY.CONNECTIONS.NAME.NETSUITE: | ||||||||
| return "Can't connec to NetSuite"; | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| default: { | ||||||||
| return "Can't connect to integration."; | ||||||||
| } | ||||||||
|
|
@@ -2469,24 +2470,15 @@ export default { | |||||||
| [CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE]: 'Not imported', | ||||||||
| [CONST.INTEGRATION_ENTITY_MAP_TYPES.REPORT_FIELD]: 'Imported as report fields', | ||||||||
| }, | ||||||||
| disconnectPrompt: (currentIntegration?: ConnectionName): string => { | ||||||||
| const integrationName = | ||||||||
| currentIntegration && CONST.POLICY.CONNECTIONS.NAME_MAP[currentIntegration] ? CONST.POLICY.CONNECTIONS.NAME_MAP[currentIntegration] : 'this integration'; | ||||||||
| return `Are you sure you want to disconnect ${integrationName}?`; | ||||||||
| }, | ||||||||
| connectPrompt: (integrationToConnect?: ConnectionName): string => { | ||||||||
| const integrationName = | ||||||||
| integrationToConnect && CONST.POLICY.CONNECTIONS.NAME_MAP[integrationToConnect] ? CONST.POLICY.CONNECTIONS.NAME_MAP[integrationToConnect] : 'this accounting integration'; | ||||||||
| return `Are you sure you want to connect ${integrationName}? This will remove any existing acounting connections.`; | ||||||||
|
There was a problem hiding this comment. Responded #44218 (comment). |
||||||||
| }, | ||||||||
| enterCredentials: 'Enter your credentials', | ||||||||
| connections: { | ||||||||
|
|
||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will match the constant names we use in the API and is also more intuitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay updated.