Race fix attempt 2 #4436
Race fix attempt 2 #4436
Conversation
| @@ -54,17 +54,23 @@ const propTypes = { | |||
| }).isRequired, | |||
|
|
|||
| /** Personal details of all the users */ | |||
| personalDetails: PropTypes.objectOf(participantPropTypes).isRequired, | |||
| personalDetails: PropTypes.objectOf(participantPropTypes), | |||
There was a problem hiding this comment.
Removing required because these throw unnecessary errors as onyx takes a while to load in these variables. I think all async variables should just be defined as not required.
| @@ -40,7 +41,7 @@ class ParticipantLocalTime extends PureComponent { | |||
| } | |||
|
|
|||
| getParticipantLocalTime() { | |||
| const reportRecipientTimezone = lodashGet(this.props.participant, 'timezone', {}); | |||
| const reportRecipientTimezone = lodashGet(this.props.participant, 'timezone', CONST.DEFAULT_TIME_ZONE); | |||
There was a problem hiding this comment.
setting a proper default because if we use {} as default then it will fail 3 lines down for currentUserDay and throw an error.
|
|
|
self merging to get it CP'd to staging soon to hopefully fix blocker. |
Race fix attempt 2 (cherry picked from commit 515feb7)
|
Confirmed this is working on staging web for me. I will test iOS once it's done building. |
|
🚀 Deployed to staging in version: 1.0.82-6🚀
|
|
For my curiosity to know how long it takes for iOS to get the testflight update, Cool, so it looks like it took an hour and 5 minutes before it was available on testflight. |
|
iOS works as well 👍 Great work @chiragsalian! |
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Details
Fixed Issues
$ #4388
Tests
sleep(10);after this lineQA Steps
Same as the issue
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android