fix: back button after deleting expense #44537

kosmydel · 2024-06-27T11:34:12Z

Details

This PR fixes the back button after deleting the expense. This might need a follow-up with a more general solution.

In this PR we moved the Delete button from the three-dot menu to RHP. To correctly navigate, we have to call the additional dismissModal method.

It might be fixed in the goBack method, but currently navigation team is busy with other issues with higher priority. They can fix it as a follow-up.

Fixed Issues

$ #44199
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Verify bug is fixed:
1. Submit two manual expenses to any user.
2. Select the grouped transactions.
3. Go to the transaction thread of any expenses.
4. Tap on the report header.
5. Tap Delete expense.
6. Delete the expense.
7. Tap on the back button on the top left.
8. Verify you are correctly redirected.
Verify other delete flows:
1. Submit one manual expense to any user.
2. Go to the transaction thread.
3. Tap on the report header.
4. Tap Delete expense.
5. Delete the expense.
6. Verify you are correctly redirected.
Do the tests from [CP Staging] Fix back navigation after delete expense request in search transcation pane RHP #44372

Offline tests

N/A

QA Steps

Tests from the above list

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mWebAndroid.mov

iOS: Native

iOS: mWeb Safari

ios.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-06-28T11:34:45Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kosmydel · 2024-06-28T11:35:19Z

@mountiny I've opened it to fix it ASAP, but it will probably require a fix in goBack function by @adamgrzybowski.

allroundexperts · 2024-06-30T22:32:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-15.at.6.35.31.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-15.at.6.34.05.PM.mov

iOS: Native

Screen.Recording.2024-07-15.at.6.30.53.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-15.at.6.26.34.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-05.at.12.54.07.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-05.at.12.58.28.PM.mov

…button

kosmydel · 2024-07-04T07:43:02Z

Hey, do you have any update @allroundexperts?

allroundexperts · 2024-07-04T08:19:28Z

Yep, I'll complete this today.

mountiny · 2024-07-05T00:06:31Z

@allroundexperts let us know if you need to reassign

allroundexperts · 2024-07-05T08:07:50Z

@kosmydel This does not seem to work on iOS Safari.

Screen.Recording.2024-07-05.at.1.03.41.PM.mov

allroundexperts · 2024-07-05T08:10:41Z

Same thing on native iOS

Screen.Recording.2024-07-05.at.1.09.50.PM.mov

kosmydel · 2024-07-05T08:42:21Z

@allroundexperts great catch!

In this case, I think we can just wait for this PR to get merged, as it removes the Delete button from the three dots menu.

allroundexperts · 2024-07-05T08:43:37Z

@allroundexperts great catch!

In this case, I think we can just wait for this PR to get merged, as it removes the Delete button from the three dots menu.

Hm... so we should change this PR to hold?

cdOut · 2024-07-05T11:31:14Z

@allroundexperts no need, we've just merged the PR you were refering to 🚀.

…button

kosmydel · 2024-07-05T15:58:34Z

I've merged the main and quickly retested. The above issues don't exist anymore, as the delete button was deleted in the three dot menu.

cc @allroundexperts

allroundexperts · 2024-07-07T16:17:55Z

This is still not working as expected @kosmydel.

Screen.Recording.2024-07-07.at.9.17.27.PM.mov

kosmydel · 2024-07-08T07:55:17Z

This is still not working as expected @kosmydel.

~~This one is also reproducible on the staging for me, especially after refreshing the website with the opened thread.~~

EDIT: I cannot reproduce it without refreshing the webpage. When you start the flow from the LHN list, does the bug occur? Is it reproducible on the main?

Video

Screen.Recording.2024-07-08.at.09.54.42.mov

My PR didn't affect this part, as its scope was to fix navigation after deleting the expense.

allroundexperts · 2024-07-09T14:58:44Z

@kosmydel Hm... without this, how can I test the PR?

kosmydel · 2024-07-09T16:41:19Z

@allroundexperts After merging the main I'm unable to reproduce this issue. Could you try once again or provide detailed reproduction steps?

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-09.at.18.37.38.mp4

kosmydel · 2024-07-15T06:00:29Z

Friendly bump @allroundexperts
I've pulled latest main

allroundexperts

Works good!

youssef-lr · 2024-07-16T18:29:48Z

Can we fix conflicts?

cdOut · 2024-07-16T21:09:16Z

@youssef-lr conflicts fixed, I've merged with the newest main.

melvin-bot · 2024-07-16T21:14:09Z

@youssef-lr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

youssef-lr · 2024-07-16T21:14:58Z

Reviewer checklist passed.

OSBotify · 2024-07-16T21:24:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-17T02:09:08Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.8-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T15:49:29Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-18T13:49:44Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T19:36:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: back button after deleting expense

c31b1d3

mountiny assigned kosmydel Jun 27, 2024

fix

6306040

kosmydel marked this pull request as ready for review June 28, 2024 11:34

kosmydel requested a review from a team as a code owner June 28, 2024 11:34

melvin-bot bot removed the request for review from a team June 28, 2024 11:34

melvin-bot bot requested a review from allroundexperts June 28, 2024 11:34

bernhardoj mentioned this pull request Jul 3, 2024

Fix inconsistency in dismissing report details RHP when deleting expense with comments #44777

Merged

50 tasks

Merge branch 'Expensify:main' into @kosmydel/fix/expense-delete-back-…

0c2bbc3

…button

mountiny requested a review from youssef-lr July 5, 2024 00:06

Merge branch 'Expensify:main' into @kosmydel/fix/expense-delete-back-…

138b5b5

…button

Merge branch 'main' into @kosmydel/fix/expense-delete-back-button

68a6655

kosmydel added 2 commits July 9, 2024 17:36

Merge branch 'main' into @kosmydel/fix/expense-delete-back-button

a730fcb

Merge branch 'main' into @kosmydel/fix/expense-delete-back-button

ba0bcac

Merge branch 'main' into @kosmydel/fix/expense-delete-back-button

43140ef

This comment was marked as outdated.

Sign in to view

allroundexperts approved these changes Jul 15, 2024

View reviewed changes

Merge branch 'main' into @kosmydel/fix/expense-delete-back-button

ce5ae9c

youssef-lr approved these changes Jul 16, 2024

View reviewed changes

youssef-lr merged commit 40aa12c into Expensify:main Jul 16, 2024
15 checks passed

melvin-bot bot added the Emergency label Jul 16, 2024

youssef-lr removed the Emergency label Jul 16, 2024

github-actions bot mentioned this pull request Jul 17, 2024

Deploy Checklist: New Expensify 2024-07-17 #45538

Closed

48 tasks

izarutskaya mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-12-17] [HOLD for payment 2024-12-16] [$250] Expense - Not here page shows up briefly when deleting the expense #45576

Closed

6 tasks

daledah mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-25] [$250] Expense - Tapping back button after deleting expense leads to not here page #44199

Closed

6 tasks

bernhardoj mentioned this pull request Jul 24, 2024

[HOLD for payment 2024-08-29] [$250] iOS - Thread - Back button in the main chat reopens main chat after leaving thread #46123

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: back button after deleting expense #44537

fix: back button after deleting expense #44537

kosmydel commented Jun 27, 2024 •

edited

Loading

melvin-bot bot commented Jun 28, 2024

kosmydel commented Jun 28, 2024

allroundexperts commented Jun 30, 2024 •

edited

Loading

kosmydel commented Jul 4, 2024

allroundexperts commented Jul 4, 2024

mountiny commented Jul 5, 2024

allroundexperts commented Jul 5, 2024

allroundexperts commented Jul 5, 2024

kosmydel commented Jul 5, 2024

allroundexperts commented Jul 5, 2024

cdOut commented Jul 5, 2024

kosmydel commented Jul 5, 2024

allroundexperts commented Jul 7, 2024

kosmydel commented Jul 8, 2024 •

edited

Loading

allroundexperts commented Jul 9, 2024

kosmydel commented Jul 9, 2024 •

edited

Loading

kosmydel commented Jul 15, 2024

This comment was marked as outdated.

allroundexperts left a comment

youssef-lr commented Jul 16, 2024

cdOut commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

youssef-lr commented Jul 16, 2024

OSBotify commented Jul 16, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

fix: back button after deleting expense #44537

fix: back button after deleting expense #44537

Conversation

kosmydel commented Jun 27, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 28, 2024

kosmydel commented Jun 28, 2024

allroundexperts commented Jun 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

kosmydel commented Jul 4, 2024

allroundexperts commented Jul 4, 2024

mountiny commented Jul 5, 2024

allroundexperts commented Jul 5, 2024

allroundexperts commented Jul 5, 2024

kosmydel commented Jul 5, 2024

allroundexperts commented Jul 5, 2024

cdOut commented Jul 5, 2024

kosmydel commented Jul 5, 2024

allroundexperts commented Jul 7, 2024

kosmydel commented Jul 8, 2024 • edited Loading

allroundexperts commented Jul 9, 2024

kosmydel commented Jul 9, 2024 • edited Loading

kosmydel commented Jul 15, 2024

This comment was marked as outdated.

allroundexperts left a comment

Choose a reason for hiding this comment

youssef-lr commented Jul 16, 2024

cdOut commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

youssef-lr commented Jul 16, 2024

OSBotify commented Jul 16, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

kosmydel commented Jun 27, 2024 •

edited

Loading

allroundexperts commented Jun 30, 2024 •

edited

Loading

kosmydel commented Jul 8, 2024 •

edited

Loading

kosmydel commented Jul 9, 2024 •

edited

Loading