-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet balance translation fix in Payments Page #4461
Wallet balance translation fix in Payments Page #4461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @johnmlee101 in version: 1.0.85-10 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
@marklouisdeshaun
Fixed Issues
#4448
Tests & QA Steps
Select preferred language to Español in Settings -> preferences.
Settings Page Near the payments option, we show a balance as
$0.00
for English. In Spanish, we show0,00 US$.
In Mobile both pages will show
$0.00
for Spanish.Fix - On the Payments page also, we will show translation for wallet balance.
Included English translations also.
Fix - For Mobile both settings & payments page we will show translation for wallet balance.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android