Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet balance translation fix in Payments Page #4461

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Aug 6, 2021

@marklouisdeshaun

Fixed Issues

#4448

Tests & QA Steps

  1. Select preferred language to Español in Settings -> preferences.

  2. Settings Page Near the payments option, we show a balance as $0.00 for English. In Spanish, we show
    0,00 US$.

  3. In Mobile both pages will show $0.00 for Spanish.

  4. Fix - On the Payments page also, we will show translation for wallet balance.
    Included English translations also.

  5. Fix - For Mobile both settings & payments page we will show translation for wallet balance.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-06 at 10 21 51 PM

Screenshot 2021-08-06 at 10 21 14 PM

Mobile Web

Screenshot 2021-08-06 at 10 49 16 PM

Screenshot 2021-08-06 at 10 49 38 PM

Desktop

Screenshot 2021-08-06 at 10 53 53 PM

Screenshot 2021-08-06 at 10 54 13 PM

iOS

Simulator Screen Shot - iPhone 11 Pro Max - 2021-08-09 at 22 17 39
Simulator Screen Shot - iPhone 11 Pro Max - 2021-08-09 at 22 25 34
Simulator Screen Shot - iPhone 11 Pro Max - 2021-08-09 at 22 24 54
Simulator Screen Shot - iPhone 11 Pro Max - 2021-08-09 at 22 24 35

Android

Screenshot_1628528779
Screenshot_1628528761
Screenshot_1628528757
Screenshot_1628528772

@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as ready for review August 12, 2021 16:51
@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner August 12, 2021 16:51
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team August 12, 2021 16:51
@Santhosh-Sellavel Santhosh-Sellavel changed the title [WIP] Wallet balance translation fix in Payments Page Wallet balance translation fix in Payments Page Aug 12, 2021
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@johnmlee101 johnmlee101 merged commit daf0025 into Expensify:main Aug 12, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 25, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 30, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants