Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import List #44663
[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import List #44663
Changes from 16 commits
1b9a19d
2d782fd
9b865aa
ef9426f
1e49875
d0d3afd
ba52be1
73f2b22
8c1251f
4d9d4e6
d4e010c
7ebd82e
77571bf
e804298
fae01d9
596ad36
545e77c
38db1b1
fa2d846
3b530fd
c1fb3a3
cbe7cd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: We should update these to be consistent at some point:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact this is broken looking at the line below: https://github.com/Expensify/App/pull/44663/files#diff-6bf4223547606b393fe6164e58be4ce31148526f088e3710737115ba4c256f3cR322
So maybe let's just fix it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is trying to do the same thing as
canUseTaxNetSuite
below - can we just reuse that method instead? Also the name is misleading here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I received the same feedback from @shubham1206agra. This method is not dependent on
canUseNetSuiteUSATax
(!!betas?.includes(CONST.BETAS.NETSUITE_USA_TAX)
). Hence I created a new one. If the logic is the same I'll use that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated to use
canUseNetSuiteUSATax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is throwing type errors due to nesting. Will fix this in upcoming PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, but then can we make the comment more descriptive than simply "Fixing in the future PR"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think during one of the merges this navigate got messed up. The current main code redirects Sage Export link to NetSuite. Added a fix here.