-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: message alignment #4503
fix: message alignment #4503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of behavior should I expect after each text message from the test steps? I do not see anything noticeable.
Sorry, @HorusGoul Forgot to mention that I will upload the screens shortly. |
Great, thanks! |
@HorusGoul All set. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Going to CP this to staging |
Ah GH Actions are currently down: https://www.githubstatus.com/ I think I'll have to try again later |
Okay, CPing this again now. Should be deployed in |
fix: message alignment (cherry picked from commit c9d2e75)
🚀 Deployed to staging in version: 1.0.83-1🚀
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
🚀 Deployed to staging by @HorusGoul in version: 1.0.83-2 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
This PR only touches base for inline code block and trimming behavior is being fixed in other PR. I have raised the issue with
react-native-render-html
and this issue is caused by the recent upgrade of this lib to v6 and As soon as the library fix this issue, I will send another PR to merge that fix.Fixed Issues
$ Fixes #4488
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iOS
Android